Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: content/public/test/render_view_test.cc

Issue 122073003: Track v8 API changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/v8_unit_test.cc ('k') | content/renderer/v8_value_converter_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index 64a4d2c67ef9ba68db05a0d553dc3e634cc87123..0a7354c470c25b9cdb974a8dd589cad0ff27856c 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -259,7 +259,8 @@ gfx::Rect RenderViewTest::GetElementBounds(const std::string& element_id) {
std::string script =
ReplaceStringPlaceholders(kGetCoordinatesScript, params, NULL);
- v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
+ v8::Isolate* isolate = v8::Isolate::GetCurrent();
+ v8::HandleScope handle_scope(isolate);
v8::Handle<v8::Value> value = GetMainFrame()->executeScriptAndReturnValue(
WebScriptSource(WebString::fromUTF8(script)));
if (value.IsEmpty() || !value->IsArray())
@@ -270,7 +271,7 @@ gfx::Rect RenderViewTest::GetElementBounds(const std::string& element_id) {
return gfx::Rect();
std::vector<int> coords;
for (int i = 0; i < 4; ++i) {
- v8::Handle<v8::Number> index = v8::Number::New(i);
+ v8::Handle<v8::Number> index = v8::Number::New(isolate, i);
v8::Local<v8::Value> value = array->Get(index);
if (value.IsEmpty() || !value->IsInt32())
return gfx::Rect();
« no previous file with comments | « chrome/test/base/v8_unit_test.cc ('k') | content/renderer/v8_value_converter_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698