Mac x86_64: Mach exception support

src/trusted/service_runtime/osx/crash_filter.h

Index: src/trusted/service_runtime/osx/crash_filter.h
===================================================================
--- src/trusted/service_runtime/osx/crash_filter.h	(revision 10790)
+++ src/trusted/service_runtime/osx/crash_filter.h	(working copy)
@@ -1,29 +0,0 @@
-/*

[Mark Seaborn, 2013/02/14 23:55:02]

Don't delete this file, please -- it's #included from the Chrome side by
breakpad_mac.mm and so is part of our interface to Chrome.  (At some point I
want to make this interface clearer by creating a directory for public headers:
https://code.google.com/p/nativeclient/issues/detail?id=2832)

Moving the file means I'd have to change the Chrome side when rolling DEPS, and
our general policy is to avoid changes that require this.

Can you rename it back to crash_filter.{h,c}?

[Mark Mentovai, 2013/02/15 17:36:42]

Mark Seaborn wrote:
This file is more than just a “crash filter” now, and I prefer not to leave old
misleading names behind. If Chrome is the only concern, I think we can handle
this easily.

What if I kept a crash_filter.h here that did nothing other than #include the
header under its new name? Then the Chromium DEPS can be rolled without having
to make any changes on the Chrome side. Once that’s done, I’ll fix the
Chrome-side #include to use the new name, and remove the transitional
crash_filter.h?

Since Chrome picks up the .cc file via the .gyp file in Native Client’s
repository, there shouldn’t be anything extra needed to account for the .cc file
changing names.

[Mark Seaborn, 2013/02/15 22:48:08]

Hmm, the new function NaClMachThreadStateIsInUntrusted() is still just a
predicate for filtering trusted vs. untrusted crashes, so the name
crash_filter.h still seems relevant to me.  mach_thread_trusted_state.h seems
more vague, but maybe that's just me.
That would work technically.

But bear in mind that I would like to remove NaClMachThreadIsInUntrusted() and
Chromium's use of it relatively soon.  (See my comment at
https://code.google.com/p/nativeclient/issues/detail?id=3087#c4)

I started working on that the other day.  My work-in-progress is here:
https://codereview.chromium.org/12278019  I realised that this work-in-progress
depends on having Mac x86-64 exception handling support in first, otherwise it
will regress run_signal_handler_test for Mac x86-64.

Implementing NaClMachThreadIsInUntrusted() for x86-64 for now seems fine, since
I know it's the last piece you need to get Chrome to link when NaCl is enabled. 
But tweaking the header file that provides it might not be worthwhile.

- * Copyright (c) 2011 The Native Client Authors. All rights reserved.
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-#ifndef NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_OSX_CRASH_FILTER_H_
-#define NATIVE_CLIENT_SRC_TRUSTED_SERVICE_RUNTIME_OSX_CRASH_FILTER_H_ 1
-
-
-#include <mach/port.h>
-
-#include "native_client/src/include/nacl_base.h"
-
-EXTERN_C_BEGIN
-
-/*
- * This function is intended for use by Chromium's embedding of
- * Breakpad crash reporting.  Given the Mach port for a thread in this
- * process that has crashed (and is suspended), this function returns
- * whether the thread crashed inside NaCl untrusted code.  This is
- * used for deciding whether to report the crash.
- */
-int NaClMachThreadIsInUntrusted(mach_port_t thread_port);
-
-EXTERN_C_END
-
-
-#endif