Issue 12278019: Mac: Enable Mach exception handler by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12278019: Mac: Enable Mach exception handler by default

Created:
7 years, 10 months ago by Mark Seaborn

Modified:
7 years, 4 months ago

Reviewers:

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Mac: Enable Mach exception handler by default This will let us remove NaClMachThreadIsInUntrusted() later (after Chrome's use of it is removed), since NaCl will always catch trusted and untrusted crashes and will decide whether to pass them on to Breakpad.

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -37 lines)			Patch
M	SConstruct	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/trusted/service_runtime/build.scons	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/trusted/service_runtime/osx/mach_exception_handler.c	View	1 2	3 chunks	+13 lines, -1 line	0 comments	Download
M	src/trusted/service_runtime/sel_main.c	View	1 2	3 chunks	+8 lines, -4 lines	0 comments	Download
M	tools/command_tester.py	View	1 2	11 chunks	+42 lines, -30 lines	0 comments	Download