Issue 12207132: Revert 182032

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12207132: Revert 182032 (Closed)

Created:
7 years, 10 months ago by brettw

Modified:
7 years, 10 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 182032 > Make base compile with no "using base::FilePath". > > For base .cc files not using the base namespace, I added a using since theses > files should be moved to the base namespace, and then explicit qualification > will no longer be necessary. > > Review URL: https://codereview.chromium.org/12226121 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182040

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -20 lines)			Patch
M	base/command_line.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/file_path.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	base/file_util.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/file_util_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_util_posix.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/json/json_file_value_serializer.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/json/json_file_value_serializer.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/nix/mime_util_xdg.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/path_service.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)