Renaming BluetoothDeviceMac as BluetoothClassicDeviceMac

Refactoring BluetoothDeviceMac to be named
BluetoothClassicDeviceMac (as its implementation was already Classic-
specific).  No changes to logic.

A follow up patch will reintroduce BluetoothDeviceMac as a
common base class for Classic and Low Energy:
https://codereview.chromium.org/1211013005/.

Committed: https://crrev.com/8cd0240fbeb389494e46e7776576013e647b14f1
Cr-Commit-Position: refs/heads/master@{#336914}

[krstnmnlsn, 2015-06-29 19:41:50]

Patchset #1 (id:1) has been deleted

[krstnmnlsn, 2015-06-29 19:43:02]

krstnmnlsn@chromium.org changed reviewers:
+ scheib@chromium.org

[krstnmnlsn, 2015-06-29 19:43:03]

Smallish change (most files contain only name-refactoring changes).  

Right now I am storing device interaction times from the call to Update(..) (see
bluetooth_low_energy_device_mac.mm).  This is probably pretty different from the
time given to Classic devices by the apple API.  Do you think this is an issue? 
(result: LE devices might hang around in |devices_| more or less time than
Classic devices do before timing out).

Thanks!

[scheib, 2015-06-29 20:44:24]

Some change in direction suggested here.

It would be cleaner to have a separate patch for just the type move of
BluetoothDeviceMac -> BluetoothClassicDeviceMac and then have the other changes
in a follow up patch.

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth.gyp (right):

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth.gyp:54: 'bluetooth_classic_device_mac.h',
Move to keep list sorted.

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_mac.mm (right):

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_mac.mm:406: // BluetoothDevice does not
currently support giving timing information (it
Drop reference to ChromeOS. How about just
"Device objects in list are either BluetoothClassicDeviceMac or
BluetoothLowEnergyDeviceMac."

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device.h (right):

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device.h:193: virtual bool SupportsLowEnergy() const;
Unless Arman is already on board with this, I think we should handle this wholly
in Mac code. Instead of type checking let's add a virtual method for what we
need. It's OK to static cast to the platform specific base class then
(BluetoothDeviceMac):

BluetoothDevice
  ^
  |
  BluetoothDeviceMac
  + NSDate* GetLastUpdateTime() = 0;
  ^ ^
  | |
  | BlueoothClassicDeviceMac
  | + NSDate* GetLastUpdateTime() { ... inquiryUpdate ... };
  | 
  BlueoothLowEnergyDeviceMac
  + NSDate* GetLastUpdateTime();


BluetoothAdapterMac::UpdateDevices() {
  ... static_cast<BluetoothDeviceMac>(device) ...

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device.h:464: bool supports_low_energy_;
Members need values in constructor or being added here with = false;

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_low_energy_device_mac.mm (right):

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_low_energy_device_mac.mm:134: // TODO(krstnmnlsn):
Remove check once we move to OSX SDK >= 10.9.
This block seems out of place for this patch. Is it needed in this patch?

[krstnmnlsn, 2015-06-29 23:10:14]

Patchset #3 (id:50001) has been deleted

[krstnmnlsn, 2015-06-30 00:50:35]

This change now only includes the refactoring of bluetooth_device_mac ->
bluetooth_classic_device_mac

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth.gyp (right):

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth.gyp:54: 'bluetooth_classic_device_mac.h',
On 2015/06/29 20:44:24, scheib wrote:
> Move to keep list sorted.

Done.

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_mac.mm (right):

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_mac.mm:406: // BluetoothDevice does not
currently support giving timing information (it
On 2015/06/29 20:44:24, scheib wrote:
> Drop reference to ChromeOS. How about just
> "Device objects in list are either BluetoothClassicDeviceMac or
> BluetoothLowEnergyDeviceMac."

Done. See https://codereview.chromium.org/1211013005/.

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device.h (right):

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device.h:193: virtual bool SupportsLowEnergy() const;
On 2015/06/29 20:44:24, scheib wrote:
> Unless Arman is already on board with this, I think we should handle this
wholly
> in Mac code. Instead of type checking let's add a virtual method for what we
> need. It's OK to static cast to the platform specific base class then
> (BluetoothDeviceMac):
> 
> BluetoothDevice
>   ^
>   |
>   BluetoothDeviceMac
>   + NSDate* GetLastUpdateTime() = 0;
>   ^ ^
>   | |
>   | BlueoothClassicDeviceMac
>   | + NSDate* GetLastUpdateTime() { ... inquiryUpdate ... };
>   | 
>   BlueoothLowEnergyDeviceMac
>   + NSDate* GetLastUpdateTime();
> 
> 
> BluetoothAdapterMac::UpdateDevices() {
>   ... static_cast<BluetoothDeviceMac>(device) ...

Done. See https://codereview.chromium.org/1211013005/.

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device.h:464: bool supports_low_energy_;
On 2015/06/29 20:44:24, scheib wrote:
> Members need values in constructor or being added here with = false;

Acknowledged.

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_low_energy_device_mac.mm (right):

https://codereview.chromium.org/1220713006/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_low_energy_device_mac.mm:134: // TODO(krstnmnlsn):
Remove check once we move to OSX SDK >= 10.9.
On 2015/06/29 20:44:24, scheib wrote:
> This block seems out of place for this patch. Is it needed in this patch?

Oh alright..

[scheib, 2015-06-30 16:46:46]

LGTM.

I edited change description some.

[krstnmnlsn, 2015-06-30 17:24:39]

krstnmnlsn@chromium.org changed reviewers:
+ armansito@chromium.org

[krstnmnlsn, 2015-06-30 17:24:40]

Thanks Vincent!  
Arman here's a small refactoring change so that Bluetooth[Classic]DeviceMac is
more accurately named.

[armansito, 2015-06-30 20:46:41]

lgtm with nit

https://codereview.chromium.org/1220713006/diff/50002/device/bluetooth/BUILD.gn
File device/bluetooth/BUILD.gn (right):

https://codereview.chromium.org/1220713006/diff/50002/device/bluetooth/BUILD....
device/bluetooth/BUILD.gn:53: "bluetooth_classic_device_mac.mm",
Let's swap the order here for consistency and also fix it elsewhere in the file.

[scheib, 2015-06-30 20:51:44]

https://codereview.chromium.org/1220713006/diff/50002/device/bluetooth/BUILD.gn
File device/bluetooth/BUILD.gn (right):

https://codereview.chromium.org/1220713006/diff/50002/device/bluetooth/BUILD....
device/bluetooth/BUILD.gn:53: "bluetooth_classic_device_mac.mm",
On 2015/06/30 20:46:41, armansito wrote:
> Let's swap the order here for consistency and also fix it elsewhere in the
file.

These lists are typically alphabetically sorted, this sort looks right.

[armansito, 2015-06-30 22:20:42]

https://codereview.chromium.org/1220713006/diff/50002/device/bluetooth/BUILD.gn
File device/bluetooth/BUILD.gn (right):

https://codereview.chromium.org/1220713006/diff/50002/device/bluetooth/BUILD....
device/bluetooth/BUILD.gn:53: "bluetooth_classic_device_mac.mm",
On 2015/06/30 20:51:43, scheib wrote:
> On 2015/06/30 20:46:41, armansito wrote:
> > Let's swap the order here for consistency and also fix it elsewhere in the
> file.
> 
> These lists are typically alphabetically sorted, this sort looks right.

Ah, OK in that case.

[krstnmnlsn, 2015-06-30 22:28:24]

The CQ bit was checked by krstnmnlsn@chromium.org

[commit-bot: I haz the power, 2015-06-30 22:30:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220713006/50002

[commit-bot: I haz the power, 2015-06-30 23:25:03]

Committed patchset #3 (id:50002)

[commit-bot: I haz the power, 2015-06-30 23:27:22]

Patchset 3 (id:??) landed as
https://crrev.com/8cd0240fbeb389494e46e7776576013e647b14f1
Cr-Commit-Position: refs/heads/master@{#336914}