Added class BluetoothDeviceMac, returns mac device timing data

Recreated class BluetoothDeviceMac, now as an interface for both
BluetoothClassicDeviceMac and BluetoothLowEnergyDeviceMac.
BluetoothDeviceMac declares pure virtual method

NSDate* GetLastUpdateTime()

which is implemented distinctly by its two subclasses and used by
the bluetooth adapter to remove unconnected devices after a
timeout.

BUG=498009
Committed: https://crrev.com/039c562fb57d67d59d784715bfa42d2120f42108
Cr-Commit-Position: refs/heads/master@{#337677}

[krstnmnlsn, 2015-06-30 00:39:18]

Patchset #1 (id:1) has been deleted

[krstnmnlsn, 2015-06-30 00:45:15]

krstnmnlsn@chromium.org changed reviewers:
+ scheib@chromium.org

[krstnmnlsn, 2015-06-30 00:45:16]

2nd half, with all relevant changes from the first half (1220713006) :)

[scheib, 2015-06-30 16:58:18]

LGTM presuming neutral answers to these questions:

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_mac.h (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_mac.h:21: BluetoothDeviceMac();
I'm presuming the chrome compile or presubmit tools required the Constructor and
Destructor? If tools allow them to be omitted, it would be cleaner as there's
really no need for the .mm file.

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_low_energy_device_mac.mm (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_low_energy_device_mac.mm:75: void
BluetoothLowEnergyDeviceMac::Update(CBPeripheral* peripheral,
If a device is known, added to the adapter, and then is discovered again in a
later scan we intend to call ::Update again, right?

[krstnmnlsn, 2015-06-30 17:39:11]

krstnmnlsn@chromium.org changed reviewers:
+ armansito@chromium.org

[krstnmnlsn, 2015-06-30 17:39:11]

Thanks x2 Vincent!

Arman here is our solution to getting the time-since-device-last-updated on mac.
 I added back BluetoothDeviceMac, now as a sort of interface for
BluetoothClassicDeviceMac and BluetoothLEDeviecMac, forcing them to implement
method GetLastUpdateTime().

Please review when you get the chance to :)

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_mac.h (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_mac.h:21: BluetoothDeviceMac();
On 2015/06/30 16:58:18, scheib wrote:
> I'm presuming the chrome compile or presubmit tools required the Constructor
and
> Destructor? If tools allow them to be omitted, it would be cleaner as there's
> really no need for the .mm file.

Tried to avoid it as well.  But the compiler complains.

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_low_energy_device_mac.mm (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_low_energy_device_mac.mm:75: void
BluetoothLowEnergyDeviceMac::Update(CBPeripheral* peripheral,
On 2015/06/30 16:58:18, scheib wrote:
> If a device is known, added to the adapter, and then is discovered again in a
> later scan we intend to call ::Update again, right?

Yes BluetoothAdapterMac::LowEnergyDeviceUpdated(...) will call it (after being
called by BluetoothLowEnergyDiscoveryManagerMac::DiscoveredPeripheral(...)).

[armansito, 2015-06-30 20:44:39]

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/BUILD.gn
File device/bluetooth/BUILD.gn (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/BUILD....
device/bluetooth/BUILD.gn:59: "bluetooth_device_mac.mm",
Swap the order (.mm first, followed by .h) for consistency

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_mac.h (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_mac.h:22: ~BluetoothDeviceMac() override;
The destructor should probably be public.

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_low_energy_device_mac.h (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_low_energy_device_mac.h:100: NSDate* last_update_time
= nil;
s/last_update_time/last_update_time_/

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_low_energy_device_mac.mm (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_low_energy_device_mac.mm:78: last_update_time =
[NSDate date];
Does Chrome have ARC enabled? If you're explicitly managing the retain count
then you'll need to either release the old NSDate instance here or use a
scoped_nsobject.

[krstnmnlsn, 2015-07-01 17:34:01]

Patchset #2 (id:40001) has been deleted

[krstnmnlsn, 2015-07-01 17:37:16]

Thanks Arman!

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/BUILD.gn
File device/bluetooth/BUILD.gn (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/BUILD....
device/bluetooth/BUILD.gn:59: "bluetooth_device_mac.mm",
On 2015/06/30 20:44:39, armansito wrote:
> Swap the order (.mm first, followed by .h) for consistency

Leaving alphabetized to appease the presubmit checks.

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_mac.h (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_mac.h:22: ~BluetoothDeviceMac() override;
On 2015/06/30 20:44:39, armansito wrote:
> The destructor should probably be public. 

Done.  Can you tell me what the thinking is?

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_low_energy_device_mac.h (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_low_energy_device_mac.h:100: NSDate* last_update_time
= nil;
On 2015/06/30 20:44:39, armansito wrote:
> s/last_update_time/last_update_time_/

thanks

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_low_energy_device_mac.mm (right):

https://codereview.chromium.org/1211013005/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_low_energy_device_mac.mm:78: last_update_time =
[NSDate date];
On 2015/06/30 20:44:39, armansito wrote:
> Does Chrome have ARC enabled? If you're explicitly managing the retain count
> then you'll need to either release the old NSDate instance here or use a
> scoped_nsobject.

We don't use ARC.  Meant for this to be a scoped_nsobject, thanks!

[krstnmnlsn, 2015-07-07 17:23:17]

The CQ bit was checked by krstnmnlsn@chromium.org to run a CQ dry run

[krstnmnlsn, 2015-07-07 17:23:18]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1211013005/#ps80001
(title: "adding a retain")

[commit-bot: I haz the power, 2015-07-07 17:25:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211013005/80001

[commit-bot: I haz the power, 2015-07-07 18:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 18:17:13]

Dry run: This issue passed the CQ dry run.

[armansito, 2015-07-07 19:10:15]

lgtm with nit

https://codereview.chromium.org/1211013005/diff/80001/device/bluetooth/blueto...
File device/bluetooth/bluetooth.gyp (right):

https://codereview.chromium.org/1211013005/diff/80001/device/bluetooth/blueto...
device/bluetooth/bluetooth.gyp:57: 'bluetooth_device_mac.h',
I realize now that this was just sorting the files alphabetically, so .h should
come first. Sorry about that...

[krstnmnlsn, 2015-07-07 20:03:31]

Thanks!

https://codereview.chromium.org/1211013005/diff/80001/device/bluetooth/blueto...
File device/bluetooth/bluetooth.gyp (right):

https://codereview.chromium.org/1211013005/diff/80001/device/bluetooth/blueto...
device/bluetooth/bluetooth.gyp:57: 'bluetooth_device_mac.h',
On 2015/07/07 19:10:15, armansito wrote:
> I realize now that this was just sorting the files alphabetically, so .h
should
> come first. Sorry about that...

Done.  Though I think the rest of this file is the other way around (presubmit
checks don't require it to alphabetize).

[krstnmnlsn, 2015-07-07 20:12:01]

Patchset #4 (id:100001) has been deleted

[krstnmnlsn, 2015-07-07 20:13:06]

https://codereview.chromium.org/1211013005/diff/80001/device/bluetooth/blueto...
File device/bluetooth/bluetooth.gyp (right):

https://codereview.chromium.org/1211013005/diff/80001/device/bluetooth/blueto...
device/bluetooth/bluetooth.gyp:57: 'bluetooth_device_mac.h',
On 2015/07/07 20:03:31, krstnmnlsn wrote:
> On 2015/07/07 19:10:15, armansito wrote:
> > I realize now that this was just sorting the files alphabetically, so .h
> should
> > come first. Sorry about that...
> 
> Done.  Though I think the rest of this file is the other way around (presubmit
> checks don't require it to alphabetize).

And undone, for consistency within this file.

[krstnmnlsn, 2015-07-07 20:15:28]

The CQ bit was checked by krstnmnlsn@chromium.org

[krstnmnlsn, 2015-07-07 20:15:29]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1211013005/#ps80001
(title: "adding a retain")

[commit-bot: I haz the power, 2015-07-07 20:15:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211013005/80001

[commit-bot: I haz the power, 2015-07-07 20:19:38]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-07-07 20:20:26]

Patchset 3 (id:??) landed as
https://crrev.com/039c562fb57d67d59d784715bfa42d2120f42108
Cr-Commit-Position: refs/heads/master@{#337677}