Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 12207128: Temporarily disable failing Win64 tests relying on pe_image (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Temporarily disable failing Win64 tests relying on pe_image 64-bit PE files aren't as predictable as 32-bit, so I'll need to modify these tests. I'm disabling them for now to get the bots on the main waterfall. R=rvargas@chromium.org,robertshield@chromium.org BUG=167707 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182078

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M base/win/pe_image_unittest.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jschuh
7 years, 10 months ago (2013-02-12 17:41:21 UTC) #1
robertshield
lgtm https://codereview.chromium.org/12207128/diff/3001/chrome/installer/util/installer_state_unittest.cc File chrome/installer/util/installer_state_unittest.cc (right): https://codereview.chromium.org/12207128/diff/3001/chrome/installer/util/installer_state_unittest.cc#newcode499 chrome/installer/util/installer_state_unittest.cc:499: // TODO(jschuh): crbug.com/167707 Please add a note that ...
7 years, 10 months ago (2013-02-12 18:01:53 UTC) #2
jschuh
+cpu, since Rick isn't a base/win owner.
7 years, 10 months ago (2013-02-12 18:14:24 UTC) #3
jschuh
https://codereview.chromium.org/12207128/diff/3001/chrome/installer/util/installer_state_unittest.cc File chrome/installer/util/installer_state_unittest.cc (right): https://codereview.chromium.org/12207128/diff/3001/chrome/installer/util/installer_state_unittest.cc#newcode499 chrome/installer/util/installer_state_unittest.cc:499: // TODO(jschuh): crbug.com/167707 On 2013/02/12 18:01:53, robertshield wrote: > ...
7 years, 10 months ago (2013-02-12 18:18:41 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
7 years, 10 months ago (2013-02-12 22:14:31 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 22:17:33 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698