Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9199)

Unified Diff: chrome/installer/util/installer_state_unittest.cc

Issue 12207128: Temporarily disable failing Win64 tests relying on pe_image (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/win/pe_image_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/installer_state_unittest.cc
===================================================================
--- chrome/installer/util/installer_state_unittest.cc (revision 181934)
+++ chrome/installer/util/installer_state_unittest.cc (working copy)
@@ -496,7 +496,15 @@
EXPECT_FALSE(MockInstallerState::IsFileInUse(temp_file));
}
-TEST_F(InstallerStateTest, RemoveOldVersionDirs) {
+// TODO(jschuh): crbug.com/167707 need to fix Win64 pe_image issues due to
+// calling upgrade_test::GenerateSpecificPEFileVersion
+#if defined(OS_WIN) && defined(ARCH_CPU_X86_64)
+#define MAYBE_RemoveOldVersionDirs DISABLED_RemoveOldVersionDirs
+#else
+#define MAYBE_RemoveOldVersionDirs RemoveOldVersionDirs
+#endif
+
+TEST_F(InstallerStateTest, MAYBE_RemoveOldVersionDirs) {
MockInstallerState installer_state;
installer_state.set_target_path(test_dir_.path());
EXPECT_EQ(test_dir_.path().value(), installer_state.target_path().value());
« no previous file with comments | « base/win/pe_image_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698