Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1220573004: Noop scrollFocusedPodIntoView on Windows, Linux and Mac (Closed)

Created:
5 years, 5 months ago by bshe
Modified:
5 years, 5 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Noop scrollFocusedPodIntoView on Windows, Linux and Mac It looks like scroll-container is not defined on Windows, Linux and Mac. They used user_manager.html instead of screen_container.html. My previous CL: codereview.chromium.org/1205063002 failed to handle this case and introduced a few regressions. This CL should fix the regressions. BUG=507219, 507212, 506800 Committed: https://crrev.com/990d54c8d31b2cb44ebc9b21b8d3596269124b81 Cr-Commit-Position: refs/heads/master@{#337486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/login/account_picker/user_pod_row.js View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
bshe
Hi Pavel. Do you mind to take a look at this CL which fixes a ...
5 years, 5 months ago (2015-07-06 15:46:01 UTC) #2
dzhioev (left Google)
On 2015/07/06 15:46:01, bshe wrote: > Hi Pavel. > > Do you mind to take ...
5 years, 5 months ago (2015-07-06 20:53:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220573004/1
5 years, 5 months ago (2015-07-06 21:03:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 21:47:24 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 21:48:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/990d54c8d31b2cb44ebc9b21b8d3596269124b81
Cr-Commit-Position: refs/heads/master@{#337486}

Powered by Google App Engine
This is Rietveld 408576698