Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1220443002: MIPS: Fix unpredictable random failures after direct api function call. (Closed)

Created:
5 years, 6 months ago by dusmil.imgtec
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix unpredictable random failures after direct api function call. The use of jalr ra is unpredictable if instruction in branch delay slot is in next page. This finally fixes random failures in JS debugger and InteruptRequest tests. TEST=mjsunit/debug-*, cctest/test-api/RequestInterruptTestWithNativeAccessor BUG= Committed: https://crrev.com/448ec36491a33111642470ad8b78e99ce3cf1975 Cr-Commit-Position: refs/heads/master@{#29331}

Patch Set 1 #

Patch Set 2 : Added asserts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M src/mips/assembler-mips.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dusmil.imgtec
PTAL.
5 years, 6 months ago (2015-06-26 14:41:07 UTC) #2
balazs.kilvady
lgtm
5 years, 6 months ago (2015-06-26 15:50:39 UTC) #3
Michael Achenbach
lgtm (rubber-stamp mjsunit.status)
5 years, 6 months ago (2015-06-26 16:20:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220443002/20001
5 years, 6 months ago (2015-06-26 16:24:49 UTC) #7
paul.l...
Very nice fix, LGTM. nit: test-api/RequestInterruptTestWith*Accessor is still on the skip list for mips eb ...
5 years, 6 months ago (2015-06-26 16:35:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-26 16:54:08 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 16:54:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/448ec36491a33111642470ad8b78e99ce3cf1975
Cr-Commit-Position: refs/heads/master@{#29331}

Powered by Google App Engine
This is Rietveld 408576698