src/mips/code-stubs-mips.cc - Issue 1220443002: MIPS: Fix unpredictable random failures after direct api function call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/code-stubs-mips.cc

Issue 1220443002: MIPS: Fix unpredictable random failures after direct api function call. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Added asserts. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/code-stubs-mips.cc

diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc

index 6a0527ffa147450bd6eca3e4aff17db0a491d923..2707c9e44b2a5f7518087f922fdf7de80cbf4f6d 100644

--- a/src/mips/code-stubs-mips.cc

+++ b/src/mips/code-stubs-mips.cc

@@ -4051,8 +4051,8 @@ void DirectCEntryStub::GenerateCall(MacroAssembler* masm,

intptr_t loc =

reinterpret_cast<intptr_t>(GetCode().location());

__ Move(t9, target);

- __ li(ra, Operand(loc, RelocInfo::CODE_TARGET), CONSTANT_SIZE);

- __ Call(ra);

+ __ li(at, Operand(loc, RelocInfo::CODE_TARGET), CONSTANT_SIZE);

+ __ Call(at);

}

« no previous file with comments | « src/mips/assembler-mips.cc ('k') | src/mips64/assembler-mips64.cc » ('j') | no next file with comments »