Issue 1220353002: Add padding values to View.idl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1220353002: Add padding values to View.idl (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add padding values to View.idl Rather than hardcoding the size and presence of the notification area in Dart, we now expose padding values on the view. These values are set to non-zero values when there are UI elements that overlap the view. We currently respect only the top padding, but this CL paves the way to respect padding in other directions. We still hardcode the size of the notification area in Java. A future CL will retrieve this value from the Android framework. Fixes #257 R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7cde360c5c3321d0af2eb622cd633be3a17ea614

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -32 lines)			Patch
M	sky/engine/core/view/View.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sky/engine/core/view/View.idl	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/engine/public/platform/sky_display_metrics.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/theme/view_configuration.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/scaffold.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	sky/services/engine/sky_engine.mojom	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java	View	3 chunks	+25 lines, -2 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyActivity.java	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	sky/shell/ios/sky_surface.mm	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	sky/shell/testing/test_runner.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.h	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	5 chunks	+15 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-06 17:56:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7cde360c5c3321d0af2eb622cd633be3a17ea614 (presubmit successful).

Expand Messages | Collapse Messages