Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java

Issue 1220353002: Add padding values to View.idl (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/services/engine/sky_engine.mojom ('k') | sky/shell/android/org/domokit/sky/shell/SkyActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java
diff --git a/sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java b/sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java
index 23f766729e6182429a535a5eac7c6b07baf4fb0b..aa807efee02286efb2597d8ee3594d295da49cbd 100644
--- a/sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java
+++ b/sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java
@@ -24,6 +24,7 @@ import org.chromium.mojom.sky.InputEvent;
import org.chromium.mojom.sky.PointerData;
import org.chromium.mojom.sky.PointerKind;
import org.chromium.mojom.sky.SkyEngine;
+import org.chromium.mojom.sky.ViewportMetrics;
/**
* A view containing Sky
@@ -37,9 +38,21 @@ public class PlatformViewAndroid extends SurfaceView
private SkyEngine.Proxy mSkyEngine;
private final SurfaceHolder.Callback mSurfaceCallback;
private GestureProvider mGestureProvider;
+ private final EdgeDims mPadding;
+
+ /**
+ * Dimensions in each of the four cardinal directions.
+ */
+ public static class EdgeDims {
+ public double top = 0.0;
+ public double right = 0.0;
+ public double bottom = 0.0;
+ public double left = 0.0;
+ }
- public PlatformViewAndroid(Context context) {
+ public PlatformViewAndroid(Context context, EdgeDims padding) {
super(context);
+ mPadding = padding;
setFocusable(true);
setFocusableInTouchMode(true);
@@ -53,7 +66,17 @@ public class PlatformViewAndroid extends SurfaceView
@Override
public void surfaceChanged(SurfaceHolder holder, int format, int width, int height) {
assert mSkyEngine != null;
- mSkyEngine.onViewportMetricsChanged(width, height, density);
+ ViewportMetrics metrics = new ViewportMetrics();
+ metrics.physicalWidth = width;
+ metrics.physicalHeight = height;
+ metrics.devicePixelRatio = density;
+ if (mPadding != null) {
+ metrics.paddingTop = mPadding.top;
+ metrics.paddingRight = mPadding.right;
+ metrics.paddingBottom = mPadding.bottom;
+ metrics.paddingLeft = mPadding.left;
+ }
+ mSkyEngine.onViewportMetricsChanged(metrics);
}
@Override
« no previous file with comments | « sky/services/engine/sky_engine.mojom ('k') | sky/shell/android/org/domokit/sky/shell/SkyActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698