Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1220283009: Debugger: do not compile IC for accessors when debugging. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: do not compile IC for accessors when debugging. The invariant is that as long as there is a debug info on the shared function info, no accessor IC is compiled for its code. That way we can guarantee that stepping into accessors, which requires a debug info, works for accessors. Committed: https://crrev.com/3dcb5171e9ba5d9f8f6f776f08c41463f1c00ae9 Cr-Commit-Position: refs/heads/master@{#29546}

Patch Set 1 #

Patch Set 2 : fix crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/debug.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Yang
Michael, I thought about this and I think your idea with conditionally compiling the IC ...
5 years, 5 months ago (2015-07-08 06:44:35 UTC) #2
mvstanton
Cool! Okay, LGTM.
5 years, 5 months ago (2015-07-08 09:43:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220283009/1
5 years, 5 months ago (2015-07-08 11:32:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/7526) (exceeded global retry quota)
5 years, 5 months ago (2015-07-08 11:42:01 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220283009/1
5 years, 5 months ago (2015-07-09 06:12:18 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/7475) (exceeded global ...
5 years, 5 months ago (2015-07-09 06:21:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220283009/20001
5 years, 5 months ago (2015-07-09 06:31:23 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-09 07:05:35 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 07:05:58 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3dcb5171e9ba5d9f8f6f776f08c41463f1c00ae9
Cr-Commit-Position: refs/heads/master@{#29546}

Powered by Google App Engine
This is Rietveld 408576698