Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: src/debug.cc

Issue 1220283009: Debugger: do not compile IC for accessors when debugging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix crash Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug.h ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index e952fe7ebb88a9dc07893f4e973be4fc5fc9ffab..b7bf3e39aa08bc12d88df301247a0c5513a810e6 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -1351,7 +1351,7 @@ void Debug::PrepareStep(StepAction step_action,
}
}
- ActivateStepIn(function, frame);
+ ActivateStepIn(frame);
}
// Fill the current function with one-shot break points even for step in on
@@ -1509,12 +1509,8 @@ void Debug::ClearOneShot() {
}
-void Debug::ActivateStepIn(Handle<JSFunction> function, StackFrame* frame) {
+void Debug::ActivateStepIn(StackFrame* frame) {
DCHECK(!StepOutActive());
- // Make sure IC state is clean. This is so that we correct flood
- // accessor pairs when stepping in.
- function->code()->ClearInlineCaches();
- function->shared()->feedback_vector()->ClearICSlots(function->shared());
thread_local_.step_into_fp_ = frame->UnpaddedFP();
}
@@ -2070,6 +2066,11 @@ bool Debug::EnsureDebugInfo(Handle<SharedFunctionInfo> shared,
return false;
}
+ // Make sure IC state is clean. This is so that we correctly flood
+ // accessor pairs when stepping in.
+ shared->code()->ClearInlineCaches();
+ shared->feedback_vector()->ClearICSlots(*shared);
+
// Create the debug info object.
Handle<DebugInfo> debug_info = isolate->factory()->NewDebugInfo(shared);
« no previous file with comments | « src/debug.h ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698