Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4166)

Unified Diff: Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 1220223003: [Background Sync] Add sync registration details to onsync event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add MODULES_EXPORT declaration to SyncRegistration Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/background_sync/SyncRegistration.cpp ('k') | Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ServiceWorkerGlobalScopeProxy.h
diff --git a/Source/web/ServiceWorkerGlobalScopeProxy.h b/Source/web/ServiceWorkerGlobalScopeProxy.h
index 4f7ae786adcc7b359fc631b816c4c12ff46c6780..b8959e7552d8e9691a241e13fbe960b5c812dd9a 100644
--- a/Source/web/ServiceWorkerGlobalScopeProxy.h
+++ b/Source/web/ServiceWorkerGlobalScopeProxy.h
@@ -46,6 +46,7 @@ class ServiceWorkerGlobalScope;
class WebEmbeddedWorkerImpl;
class WebServiceWorkerContextClient;
class WebServiceWorkerRequest;
+struct WebSyncRegistration;
// This class is created and destructed on the main thread, but live most
// of its time as a resident of the worker thread.
@@ -78,7 +79,10 @@ public:
virtual void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray&) override;
virtual void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&) override;
virtual void dispatchPushEvent(int, const WebString& data) override;
+ // FIXME: Remove the single-parameter version once all call sites have been
Michael van Ouwerkerk 2015/07/07 14:07:35 The style is now TODO(name) https://www.chromium.
iclelland 2015/07/07 14:37:24 Fixed (all three occurrences) -- thanks!
+ // updated.
virtual void dispatchSyncEvent(int) override;
+ virtual void dispatchSyncEvent(int, const WebSyncRegistration&) override;
virtual void addStashedMessagePorts(const WebMessagePortChannelArray&, const WebVector<WebString>& webChannelNames) override;
// WorkerReportingProxy overrides:
« no previous file with comments | « Source/modules/background_sync/SyncRegistration.cpp ('k') | Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698