[Background Sync] Add sync registration details to onsync event

Source/web/ServiceWorkerGlobalScopeProxy.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "wtf/OwnPtr.h"
 
 namespace blink {
 
 class ConsoleMessage;
 class Document;
 class ServiceWorkerGlobalScope;
 class WebEmbeddedWorkerImpl;
 class WebServiceWorkerContextClient;
 class WebServiceWorkerRequest;
+struct WebSyncRegistration;
 
 // This class is created and destructed on the main thread, but live most
 // of its time as a resident of the worker thread.
 // All methods other than its ctor/dtor are called on the worker thread.
 //
 // This implements WebServiceWorkerContextProxy, which connects ServiceWorker's
 // WorkerGlobalScope and embedder/chrome, and implements ServiceWorker-specific
 // events/upcall methods that are to be called by embedder/chromium,
 // e.g. onfetch.
 //
@@ skipping 12 matching lines @@
     virtual void setRegistration(WebServiceWorkerRegistration*) override;
     virtual void dispatchActivateEvent(int) override;
     virtual void dispatchCrossOriginConnectEvent(int, const WebCrossOriginServiceWorkerClient&) override;
     virtual void dispatchCrossOriginMessageEvent(const WebCrossOriginServiceWorkerClient&, const WebString& message, const WebMessagePortChannelArray&) override;
     virtual void dispatchFetchEvent(int, const WebServiceWorkerRequest&) override;
     virtual void dispatchGeofencingEvent(int, WebGeofencingEventType, const WebString& regionID, const WebCircularGeofencingRegion&) override;
     virtual void dispatchInstallEvent(int) override;
     virtual void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray&) override;
     virtual void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&) override;
     virtual void dispatchPushEvent(int, const WebString& data) override;
+    // FIXME: Remove the single-parameter version once all call sites have been

[Michael van Ouwerkerk, 2015/07/07 14:07:35]

The style is now TODO(name)

https://www.chromium.org/blink/coding-style#TOC-Comments

[iclelland, 2015/07/07 14:37:24]

Fixed (all three occurrences) -- thanks!

+    // updated.
     virtual void dispatchSyncEvent(int) override;
+    virtual void dispatchSyncEvent(int, const WebSyncRegistration&) override;
     virtual void addStashedMessagePorts(const WebMessagePortChannelArray&, const WebVector<WebString>& webChannelNames) override;
 
     // WorkerReportingProxy overrides:
     virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;
     virtual void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;
     virtual void postMessageToPageInspector(const String&) override;
     virtual void postWorkerConsoleAgentEnabled() override { }
     virtual void didEvaluateWorkerScript(bool success) override;
     virtual void workerGlobalScopeStarted(WorkerGlobalScope*) override;
     virtual void workerGlobalScopeClosed() override;
     virtual void willDestroyWorkerGlobalScope() override;
     virtual void workerThreadTerminated() override;
 
 private:
     ServiceWorkerGlobalScopeProxy(WebEmbeddedWorkerImpl&, Document&, WebServiceWorkerContextClient&);
 
     WebEmbeddedWorkerImpl& m_embeddedWorker;
     Document& m_document;
 
     WebServiceWorkerContextClient& m_client;
 
     ServiceWorkerGlobalScope* m_workerGlobalScope;
 };
 
 } // namespace blink
 
 #endif // ServiceWorkerGlobalScopeProxy_h