[Background Sync] Add sync registration details to onsync event

[Background Sync] Add sync registration details to onsync event

This is the first of a series of changes across Blink and Chromium to send the sync registration details from the BackgroundSyncManager to a running Service Worker.

This change adds a new 2-argument dispatchSyncEvent() method to ServiceWorkerGlobalScopeProxy. Once the Chromium-side calls to the original (1-arg) method have been converted, the original method will be removed.

BUG=482066
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198795

[iclelland, 2015-07-06 18:45:05]

iclelland@chromium.org changed reviewers:
+ jochen@chromium.org, mvanouwerkerk@chromium.org

[iclelland, 2015-07-06 18:46:21]

iclelland@chromium.org changed reviewers:
+ jkarlin@chromium.org

[iclelland, 2015-07-06 18:48:54]

Michael -- since jkarlin is on vacation, can you take a look at this? (I have
the chromium side ready as well, but it's waiting on this and on mek's
https://codereview.chromium.org/1221503003 - or something like it)

[Michael van Ouwerkerk, 2015-07-07 14:07:35]

lgtm with nit

https://codereview.chromium.org/1220223003/diff/40001/Source/web/ServiceWorke...
File Source/web/ServiceWorkerGlobalScopeProxy.h (right):

https://codereview.chromium.org/1220223003/diff/40001/Source/web/ServiceWorke...
Source/web/ServiceWorkerGlobalScopeProxy.h:82: // FIXME: Remove the
single-parameter version once all call sites have been
The style is now TODO(name)

https://www.chromium.org/blink/coding-style#TOC-Comments

[iclelland, 2015-07-07 14:37:24]

https://codereview.chromium.org/1220223003/diff/40001/Source/web/ServiceWorke...
File Source/web/ServiceWorkerGlobalScopeProxy.h (right):

https://codereview.chromium.org/1220223003/diff/40001/Source/web/ServiceWorke...
Source/web/ServiceWorkerGlobalScopeProxy.h:82: // FIXME: Remove the
single-parameter version once all call sites have been
On 2015/07/07 14:07:35, Michael van Ouwerkerk wrote:
> The style is now TODO(name)
> 
> https://www.chromium.org/blink/coding-style#TOC-Comments

Fixed (all three occurrences) -- thanks!

[iclelland, 2015-07-08 03:24:54]

jochen -- could you take a look as an owner? Thanks

[jochen (gone - plz use gerrit), 2015-07-13 08:55:39]

lgtm

[jkarlin, 2015-07-13 11:49:05]

lgtm with nit

https://codereview.chromium.org/1220223003/diff/80001/Source/web/ServiceWorke...
File Source/web/ServiceWorkerGlobalScopeProxy.h (right):

https://codereview.chromium.org/1220223003/diff/80001/Source/web/ServiceWorke...
Source/web/ServiceWorkerGlobalScopeProxy.h:83: // TODO(iclelland): Remove the
single-parameter version once all call sites
"all call sites *are* updated"

[iclelland, 2015-07-13 13:23:32]

The CQ bit was checked by iclelland@chromium.org

[iclelland, 2015-07-13 13:23:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org, jkarlin@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1220223003/#ps100001
(title: "Fix: Missing words in comment")

[commit-bot: I haz the power, 2015-07-13 13:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1220223003/100001

[commit-bot: I haz the power, 2015-07-13 17:07:01]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198795