remoting/test/app_remoting_latency_test_fixture.h - Issue 1219923011: Added image pattern comparison logic for test interface and fixture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/test/app_remoting_latency_test_fixture.h

Issue 1219923011: Added image pattern comparison logic for test interface and fixture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: "Addressed feedback from Joe and Updated connection helper with base::ResetAndReturn()" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/test/app_remoting_connection_helper.cc ('k') | remoting/test/app_remoting_latency_test_fixture.cc » ('j') | remoting/test/test_video_renderer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/test/app_remoting_latency_test_fixture.h

diff --git a/remoting/test/app_remoting_latency_test_fixture.h b/remoting/test/app_remoting_latency_test_fixture.h

index 1cebe84a935ed3cf57e18177f1843bbc74592c66..7ad0f4c9f5191779ce31e8e2731ea7b06b641e79 100644

--- a/remoting/test/app_remoting_latency_test_fixture.h

+++ b/remoting/test/app_remoting_latency_test_fixture.h

@@ -30,7 +30,7 @@ struct RemoteApplicationDetails;

class AppRemotingConnectionHelper;

class TestVideoRenderer;

-typedef uint32 RgbaColor;

+typedef uint32 RGBA32;

Sergey Ulanov 2015/07/09 19:43:13 Please don't duplicate type definition. I might be

liaoyuke 2015/07/09 23:21:00 Done.

// Creates a connection to a remote host which is available for tests to use.

// Provides convenient methods to create test cases to measure the input and

@@ -46,7 +46,7 @@ class AppRemotingLatencyTestFixture : public testing::Test {

// Set expected image pattern for comparison and a matched reply will be

// called when the pattern is matched.

void SetExpectedImagePattern(const webrtc::DesktopRect& expected_rect,

- const RgbaColor& expected_color);

+ const RGBA32& expected_color);

// Waits for an image pattern matched reply up to |max_wait_time|. Returns

// true if we received a response within the maximum time limit.

@@ -54,7 +54,7 @@ class AppRemotingLatencyTestFixture : public testing::Test {

bool WaitForImagePatternMatched(const base::TimeDelta& max_wait_time);

// Name of the application being tested.

- // NOTE: must be initialized in the constructor of derived class.

+ // NOTE: Must be initialized in the constructor of derived class.

std::string application_name_;

private: