Added image pattern comparison logic for test interface and fixture.

remoting/test/app_remoting_latency_test_fixture.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_TEST_APP_REMOTING_LATENCY_TEST_FIXTURE_H_
 #define REMOTING_TEST_APP_REMOTING_LATENCY_TEST_FIXTURE_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 12 matching lines @@
 class DesktopRect;
 }
 
 namespace remoting {
 namespace test {
 
 struct RemoteApplicationDetails;
 class AppRemotingConnectionHelper;
 class TestVideoRenderer;
 
-typedef uint32 RgbaColor;
+typedef uint32 RGBA32;

[Sergey Ulanov, 2015/07/09 19:43:13]

Please don't duplicate type definition. I might be better to just use uint32_t
everywhere, unless there are many more places where we need to pass this value.

[liaoyuke, 2015/07/09 23:21:00]

Done.

 
 // Creates a connection to a remote host which is available for tests to use.
 // Provides convenient methods to create test cases to measure the input and
 // rendering latency between client and the remote host.
 // NOTE: This is an abstract class. To use it, please derive from this class
 // and initialize the application names in constructor.
 class AppRemotingLatencyTestFixture : public testing::Test {
  public:
   AppRemotingLatencyTestFixture();
   ~AppRemotingLatencyTestFixture() override;
 
  protected:
   // Set expected image pattern for comparison and a matched reply will be
   // called when the pattern is matched.
   void SetExpectedImagePattern(const webrtc::DesktopRect& expected_rect,
-                               const RgbaColor& expected_color);
+                               const RGBA32& expected_color);
 
   // Waits for an image pattern matched reply up to |max_wait_time|. Returns
   // true if we received a response within the maximum time limit.
   // NOTE: SetExpectedImagePattern() must be called before calling this method.
   bool WaitForImagePatternMatched(const base::TimeDelta& max_wait_time);
 
   // Name of the application being tested.
-  // NOTE: must be initialized in the constructor of derived class.
+  // NOTE: Must be initialized in the constructor of derived class.
   std::string application_name_;
 
  private:
   // testing::Test interface.
   void SetUp() override;
   void TearDown() override;
 
   // Contains the details for the application being tested.
   const RemoteApplicationDetails& application_details_;
 
@@ skipping 14 matching lines @@
   // TestChromotingClient own its lifetime.
   base::WeakPtr<TestVideoRenderer> test_video_renderer_;
 
   DISALLOW_COPY_AND_ASSIGN(AppRemotingLatencyTestFixture);
 };
 
 }  // namespace test
 }  // namespace remoting
 
 #endif  // REMOTING_TEST_APP_REMOTING_LATENCY_TEST_FIXTURE_H_