Issue 1219683015: Convert //shell/... to use set_connection_error_handler() instead of set_error_handler().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1219683015: Convert //shell/... to use set_connection_error_handler() instead of set_error_handler(). (Closed)

Created:
5 years, 5 months ago by viettrungluu

Modified:
5 years, 5 months ago

Reviewers:
rudominer

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Convert //shell/... to use set_connection_error_handler() instead of set_error_handler(). (The latter is deprecated.) R=rudominer@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/01e64cf8cadcfa09fb24074f375d4fdc848930be

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -64 lines)			Patch
M	shell/application_manager/application_manager.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	shell/application_manager/application_manager_unittest.cc	View	2 chunks	+2 lines, -16 lines	0 comments	Download
M	shell/application_manager/shell_impl.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	shell/application_manager/shell_impl.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	shell/child_main.cc	View	3 chunks	+9 lines, -10 lines	0 comments	Download
M	shell/child_process_host.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	shell/child_process_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	shell/shell_test_base_unittest.cc	View	3 chunks	+4 lines, -18 lines	0 comments	Download

Total messages: 5 (1 generated)

viettrungluu

5 years, 5 months ago (2015-07-08 16:55:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
01e64cf8cadcfa09fb24074f375d4fdc848930be (presubmit successful).