Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: shell/child_process_host.h

Issue 1219683015: Convert //shell/... to use set_connection_error_handler() instead of set_error_handler(). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/child_main.cc ('k') | shell/child_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/child_process_host.h
diff --git a/shell/child_process_host.h b/shell/child_process_host.h
index 67f243d37ba58e2ce8b8e9f1e8b2d3a3cdbbd302..d065ce60ca1c80e2d8827829b8c03e0614229c82 100644
--- a/shell/child_process_host.h
+++ b/shell/child_process_host.h
@@ -27,10 +27,12 @@ class Context;
//
// This class is not thread-safe. It should be created/used/destroyed on a
// single thread.
-class ChildProcessHost : public mojo::ErrorHandler {
+class ChildProcessHost {
public:
explicit ChildProcessHost(Context* context);
- ~ChildProcessHost() override;
+ // TODO(vtl): Virtual because |DidStart()| is, even though it shouldn't be
+ // (see |DidStart()|).
+ virtual ~ChildProcessHost();
// |Start()|s the child process; calls |DidStart()| (on the thread on which
// |Start()| was called) when the child has been started (or failed to start).
@@ -73,9 +75,7 @@ class ChildProcessHost : public mojo::ErrorHandler {
base::Process DoLaunch(scoped_ptr<LaunchData> launch_data);
void AppCompleted(int32_t result);
-
- // |mojo::ErrorHandler| methods:
- void OnConnectionError() override;
+ void OnConnectionError();
Context* const context_;
« no previous file with comments | « shell/child_main.cc ('k') | shell/child_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698