Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1219673003: Sync core/timing/ interfaces with their specs, or lack thereof (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
Kunihiko Sakamoto
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung, igrigorik
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync core/timing/ interfaces with their specs, or lack thereof The only changes to the generated code are ordering and the added use counters. [Measure] does not mean that we should try to remove it, in cases where usage is high we can use that data to ask for spec changes. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198682

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 7

Patch Set 4 : address feedback #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -66 lines) Patch
M Source/core/core.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/timing/ConsoleMemory.idl View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A + Source/core/timing/DOMHighResTimeStamp.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/timing/MemoryInfo.idl View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M Source/core/timing/Performance.idl View 1 2 3 1 chunk +37 lines, -17 lines 0 comments Download
M Source/core/timing/PerformanceCompositeTiming.idl View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/timing/PerformanceEntry.idl View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
A + Source/core/timing/PerformanceEntryList.idl View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/timing/PerformanceMark.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/timing/PerformanceMeasure.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/timing/PerformanceNavigation.idl View 1 2 chunks +6 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceRenderTiming.idl View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/timing/PerformanceResourceTiming.idl View 1 2 1 chunk +22 lines, -14 lines 0 comments Download
M Source/core/timing/PerformanceTiming.idl View 1 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/timing/SharedWorkerPerformance.idl View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/timing/WindowPerformance.idl View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/timing/WorkerGlobalScopePerformance.idl View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/timing/WorkerPerformance.idl View 1 2 3 1 chunk +19 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
Sakamoto-san, PTAL. This is messier than many spec sync CLs, but Ilya had a nice ...
5 years, 5 months ago (2015-07-09 18:30:48 UTC) #2
Kunihiko Sakamoto
Very nice, thanks! https://codereview.chromium.org/1219673003/diff/40001/Source/core/timing/Performance.idl File Source/core/timing/Performance.idl (right): https://codereview.chromium.org/1219673003/diff/40001/Source/core/timing/Performance.idl#newcode50 Source/core/timing/Performance.idl:50: // TODO(philipj): Unprefix thes APIs. s/thes/these/ ...
5 years, 5 months ago (2015-07-10 06:37:56 UTC) #3
philipj_slow
https://codereview.chromium.org/1219673003/diff/40001/Source/core/timing/Performance.idl File Source/core/timing/Performance.idl (right): https://codereview.chromium.org/1219673003/diff/40001/Source/core/timing/Performance.idl#newcode50 Source/core/timing/Performance.idl:50: // TODO(philipj): Unprefix thes APIs. On 2015/07/10 06:37:55, Kunihiko ...
5 years, 5 months ago (2015-07-10 08:18:14 UTC) #4
Kunihiko Sakamoto
lgtm https://codereview.chromium.org/1219673003/diff/40001/Source/core/timing/WorkerGlobalScopePerformance.idl File Source/core/timing/WorkerGlobalScopePerformance.idl (right): https://codereview.chromium.org/1219673003/diff/40001/Source/core/timing/WorkerGlobalScopePerformance.idl#newcode31 Source/core/timing/WorkerGlobalScopePerformance.idl:31: // TODO(philipj): There is no spec for Performance ...
5 years, 5 months ago (2015-07-10 08:28:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219673003/80001
5 years, 5 months ago (2015-07-10 11:32:12 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 12:23:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198682

Powered by Google App Engine
This is Rietveld 408576698