Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: Source/core/timing/ConsoleMemory.idl

Issue 1219673003: Sync core/timing/ interfaces with their specs, or lack thereof (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/timing/DOMHighResTimeStamp.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/timing/ConsoleMemory.idl
diff --git a/Source/core/timing/ConsoleMemory.idl b/Source/core/timing/ConsoleMemory.idl
index 7aa4952a4b224e0a68e9553060907557f3f0cff8..2cf01b61ecfc8d0a7e622e12f676c1766f1a5121 100644
--- a/Source/core/timing/ConsoleMemory.idl
+++ b/Source/core/timing/ConsoleMemory.idl
@@ -2,9 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-[
- ImplementedAs=ConsoleMemory,
-] partial interface Console {
+// TODO(philipj): There is no spec for the Memory Info API, see blink-dev:
+// https://groups.google.com/a/chromium.org/d/msg/blink-dev/g5YRCGpC9vs/b4OJz71NmPwJ
+
+partial interface Console {
// We can't make the attribute readonly as it breaks existing code that relies on being able to assign to console.memory in strict mode. Instead, the setter just ignores the passed value. http://crbug.com/468611
- attribute MemoryInfo memory;
+ [Measure] attribute MemoryInfo memory;
};
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/timing/DOMHighResTimeStamp.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698