Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 12194030: Rename mount (Closed)

Created:
7 years, 10 months ago by noelallen1
Modified:
7 years, 10 months ago
Reviewers:
binji
CC:
chromium-reviews, binji, Sam Clegg
Visibility:
Public.

Description

Rename mount Rename nacl_mounts to nacl_io since we plan to support more than just file mounts. TBR=binji@chromium.org BUG=174171 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180793

Patch Set 1 #

Patch Set 2 : Fix c file. #

Total comments: 14

Patch Set 3 : Fix include guard, alignment, text #

Patch Set 4 : Fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -9587 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/test_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/Makefile View 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/example.dsc View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/example.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/handlers.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/handlers.c View 1 chunk +1 line, -1 line 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/hello_nacl_io.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/hello_nacl_io.c View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/index.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/queue.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/examples/hello_nacl_io/queue.c View 0 chunks +-1 lines, --1 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/Makefile View 1 chunk +0 lines, -81 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/example.dsc View 1 chunk +0 lines, -32 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/example.js View 1 chunk +0 lines, -182 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/handlers.h View 1 chunk +0 lines, -19 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/handlers.c View 1 chunk +0 lines, -322 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/hello_nacl_mounts.h View 1 chunk +0 lines, -18 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/hello_nacl_mounts.c View 1 chunk +0 lines, -361 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/index.html View 1 chunk +0 lines, -106 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/queue.h View 1 chunk +0 lines, -30 lines 0 comments Download
D native_client_sdk/src/examples/hello_nacl_mounts/queue.c View 1 chunk +0 lines, -115 lines 0 comments Download
M native_client_sdk/src/examples/hello_world_instance3d/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_instance3d/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_instance3d/hello_world.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_stdio/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/hello_world_stdio/example.dsc View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/hello_world_stdio/index.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/inode_pool.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_handle.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_handle.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_intercept.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_object.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_object.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_proxy.h View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc View 2 chunks +11 lines, -11 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_wrap.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_wrap_glibc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/kernel_wrap_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/library.dsc View 6 chunks +6 lines, -6 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_dev.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_dev.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_html5fs.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_html5fs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_http.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_http.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_mem.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_mem.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_node.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_node.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_node_dir.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_node_mem.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/mount_node_mem.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/nacl_io.h View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/nacl_io.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/nacl_mounts.vcproj View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/osdirent.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/osinttypes.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/osstat.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/ostypes.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/path.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/path.cc View 1 chunk +1 line, -1 line 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/pepper/all_interfaces.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/pepper/define_empty_macros.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/pepper/undef_macros.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/pepper_interface.h View 1 2 5 chunks +11 lines, -11 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/pepper_interface.cc View 1 chunk +1 line, -1 line 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/real_pepper_interface.h View 1 2 4 chunks +12 lines, -12 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/real_pepper_interface.cc View 5 chunks +11 lines, -11 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/example.dsc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/example.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/kernel_object_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/kernel_proxy_mock.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/kernel_proxy_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/kernel_proxy_test.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/kernel_wrap_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/module.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/mount_html5fs_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/mount_http_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/mount_node_test.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/mount_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/nacl_mounts_test.vcproj.GOOGLE.noelallen.user View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/path_test.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/pepper_interface_mock.h View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io_test/pepper_interface_mock.cc View 4 chunks +9 lines, -9 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/Makefile View 1 chunk +0 lines, -57 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/inode_pool.h View 1 chunk +0 lines, -65 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_handle.h View 1 chunk +0 lines, -41 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_handle.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_intercept.h View 1 chunk +0 lines, -58 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_intercept.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_object.h View 1 chunk +0 lines, -62 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_object.cc View 1 chunk +0 lines, -172 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_proxy.h View 1 chunk +0 lines, -102 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_proxy.cc View 1 chunk +0 lines, -431 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_wrap.h View 1 chunk +0 lines, -85 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_wrap_glibc.cc View 1 chunk +0 lines, -299 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_wrap_newlib.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/kernel_wrap_win.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/library.dsc View 1 chunk +0 lines, -89 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount.h View 1 chunk +0 lines, -92 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_dev.h View 1 chunk +0 lines, -41 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_dev.cc View 1 chunk +0 lines, -282 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_html5fs.h View 1 chunk +0 lines, -42 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_html5fs.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_http.h View 1 chunk +0 lines, -54 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_http.cc View 1 chunk +0 lines, -685 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_mem.h View 1 chunk +0 lines, -54 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_mem.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_node.h View 1 chunk +0 lines, -75 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_node.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_node_dir.h View 1 chunk +0 lines, -54 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_node_dir.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.h View 1 chunk +0 lines, -41 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_node_html5fs.cc View 1 chunk +0 lines, -254 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_node_mem.h View 1 chunk +0 lines, -29 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/mount_node_mem.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/nacl_mounts.h View 1 chunk +0 lines, -111 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/nacl_mounts.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/nacl_mounts.vcproj View 1 chunk +0 lines, -212 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/osdirent.h View 1 chunk +0 lines, -26 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/osinttypes.h View 1 chunk +0 lines, -34 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/osstat.h View 1 chunk +0 lines, -22 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/ostypes.h View 1 chunk +0 lines, -19 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/path.h View 1 chunk +0 lines, -69 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/path.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/pepper/all_interfaces.h View 1 chunk +0 lines, -94 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/pepper/define_empty_macros.h View 1 chunk +0 lines, -13 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/pepper/undef_macros.h View 1 chunk +0 lines, -12 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/pepper_interface.h View 1 chunk +0 lines, -101 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/pepper_interface.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/real_pepper_interface.h View 1 chunk +0 lines, -54 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts/real_pepper_interface.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/Makefile View 1 chunk +0 lines, -86 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/example.dsc View 1 chunk +0 lines, -36 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/example.js View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/index.html View 1 chunk +0 lines, -23 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/kernel_object_test.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/kernel_proxy_mock.h View 1 chunk +0 lines, -48 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/kernel_proxy_mock.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/kernel_proxy_test.cc View 1 chunk +0 lines, -244 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/kernel_wrap_test.cc View 1 chunk +0 lines, -232 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/module.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/mount_html5fs_test.cc View 1 chunk +0 lines, -357 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/mount_http_test.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/mount_node_test.cc View 1 chunk +0 lines, -190 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/mount_test.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/nacl_mounts_test.vcproj.GOOGLE.noelallen.user View 1 chunk +0 lines, -65 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/path_test.cc View 1 chunk +0 lines, -258 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/pepper_interface_mock.h View 1 chunk +0 lines, -66 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_mounts_test/pepper_interface_mock.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_main/ppapi_instance.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_main/ppapi_instance3d.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
noelallen1
ptal This looks worse than it is. It's actually a rename of 'nacl_mounts' to nacl_io. ...
7 years, 10 months ago (2013-02-04 22:54:08 UTC) #1
noelallen1
$ grep --include="Makefile" --include="*.dsc" --include="*.py" --include="*.cc" --include="*.h" -nr -F "nacl_mount" . $
7 years, 10 months ago (2013-02-04 22:55:28 UTC) #2
binji
lgtm try looking for _MOUNTS_ to get the header guards. https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/examples/hello_nacl_io/example.dsc File native_client_sdk/src/examples/hello_nacl_io/example.dsc (right): https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/examples/hello_nacl_io/example.dsc#newcode24 ...
7 years, 10 months ago (2013-02-05 21:04:14 UTC) #3
noelallen1
7 years, 10 months ago (2013-02-05 21:21:47 UTC) #4
https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/exam...
File native_client_sdk/src/examples/hello_nacl_io/example.dsc (right):

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/exam...
native_client_sdk/src/examples/hello_nacl_io/example.dsc:24: 'TITLE': 'Hello,
Nacl Mounts!',
On 2013/02/05 21:04:14, binji wrote:
> Nacl IO

Done.

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/exam...
native_client_sdk/src/examples/hello_nacl_io/example.dsc:26: The NaCl Mounts
example demonstrates mapping standard FILE such as fopen,
On 2013/02/05 21:04:14, binji wrote:
> The NaCl IO

Done.

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/exam...
native_client_sdk/src/examples/hello_nacl_io/example.dsc:30: 'FOCUS': 'Using
NaCl Mounts.',
On 2013/02/05 21:04:14, binji wrote:
> IO

Done.

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/exam...
File native_client_sdk/src/examples/hello_nacl_io/hello_nacl_io.h (right):

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/exam...
native_client_sdk/src/examples/hello_nacl_io/hello_nacl_io.h:6: #ifndef
HELLO_NACL_MOUNTS_H_
On 2013/02/05 21:04:14, binji wrote:
> HELLO_NACL_IO_H_

Done.

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/libr...
File native_client_sdk/src/libraries/nacl_io/inode_pool.h (right):

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/libr...
native_client_sdk/src/libraries/nacl_io/inode_pool.h:6: #ifndef
LIBRARIES_NACL_MOUNTS_INODE_POOL_H_
On 2013/02/05 21:04:14, binji wrote:
> IO

Done.

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/libr...
File native_client_sdk/src/libraries/nacl_io/nacl_io.h (right):

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/libr...
native_client_sdk/src/libraries/nacl_io/nacl_io.h:42: PPB_GetInterface
get_interface);
On 2013/02/05 21:04:14, binji wrote:
> nit: align

Done.

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/libr...
File native_client_sdk/src/libraries/nacl_io_test/example.dsc (right):

https://codereview.chromium.org/12194030/diff/4001/native_client_sdk/src/libr...
native_client_sdk/src/libraries/nacl_io_test/example.dsc:35: 'TITLE': 'NaCl
Mounts test',
On 2013/02/05 21:04:14, binji wrote:
> NaCl IO Test

Done.

Powered by Google App Engine
This is Rietveld 408576698