Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: content/browser/android/date_time_chooser_android.h

Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased view_messages.h and fixed the link issue on the linux bot Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/date_time_chooser_android.h
diff --git a/content/browser/android/date_time_chooser_android.h b/content/browser/android/date_time_chooser_android.h
index 787b0caf7ab8f37763acda87138f227f174e50ef..c33c5c425b3f05867af9647c57a6849c0eeb826e 100644
--- a/content/browser/android/date_time_chooser_android.h
+++ b/content/browser/android/date_time_chooser_android.h
@@ -24,10 +24,13 @@ class DateTimeChooserAndroid {
// DateTimeChooser implementation:
void ShowDialog(ContentViewCore* content,
RenderViewHost* sender,
- int type, const std::string& value);
+ int type, int year, int month, int day,
+ int hour, int minute, int second);
- // Replaces the current value with the one passed in text.
- void ReplaceDateTime(JNIEnv* env, jobject, jstring text);
+ // Replaces the current value with the one passed the different fields
+ void ReplaceDateTime(JNIEnv* env, jobject, jint dialog_type,
+ jint year, jint month, jint day,
+ jint hour, jint minute, jint second);
// Closes the dialog without propagating any changes.
void CancelDialog(JNIEnv* env, jobject);
@@ -42,7 +45,7 @@ class DateTimeChooserAndroid {
private:
class DateTimeIPCSender;
- scoped_ptr<DateTimeIPCSender> communicator_;
+ scoped_ptr<DateTimeIPCSender> sender_;
base::android::ScopedJavaGlobalRef<jobject> j_date_time_chooser_;
DISALLOW_COPY_AND_ASSIGN(DateTimeChooserAndroid);
« no previous file with comments | « no previous file | content/browser/android/date_time_chooser_android.cc » ('j') | content/renderer/date_time_formatter.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698