Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: content/browser/android/date_time_chooser_android.h

Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased view_messages.h and fixed the link issue on the linux bot Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
6 #define CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_ 6 #define CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/android/jni_helper.h" 10 #include "base/android/jni_helper.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 class ContentViewCore; 15 class ContentViewCore;
16 class RenderViewHost; 16 class RenderViewHost;
17 17
18 // Android implementation for DateTimeChooser dialogs. 18 // Android implementation for DateTimeChooser dialogs.
19 class DateTimeChooserAndroid { 19 class DateTimeChooserAndroid {
20 public: 20 public:
21 DateTimeChooserAndroid(); 21 DateTimeChooserAndroid();
22 ~DateTimeChooserAndroid(); 22 ~DateTimeChooserAndroid();
23 23
24 // DateTimeChooser implementation: 24 // DateTimeChooser implementation:
25 void ShowDialog(ContentViewCore* content, 25 void ShowDialog(ContentViewCore* content,
26 RenderViewHost* sender, 26 RenderViewHost* sender,
27 int type, const std::string& value); 27 int type, int year, int month, int day,
28 int hour, int minute, int second);
28 29
29 // Replaces the current value with the one passed in text. 30 // Replaces the current value with the one passed the different fields
30 void ReplaceDateTime(JNIEnv* env, jobject, jstring text); 31 void ReplaceDateTime(JNIEnv* env, jobject, jint dialog_type,
32 jint year, jint month, jint day,
33 jint hour, jint minute, jint second);
31 34
32 // Closes the dialog without propagating any changes. 35 // Closes the dialog without propagating any changes.
33 void CancelDialog(JNIEnv* env, jobject); 36 void CancelDialog(JNIEnv* env, jobject);
34 37
35 // Propagates the different types of accepted date/time values to the 38 // Propagates the different types of accepted date/time values to the
36 // java side. 39 // java side.
37 static void InitializeDateInputTypes( 40 static void InitializeDateInputTypes(
38 int text_input_type_date, int text_input_type_date_time, 41 int text_input_type_date, int text_input_type_date_time,
39 int text_input_type_date_time_local, int text_input_type_month, 42 int text_input_type_date_time_local, int text_input_type_month,
40 int text_input_type_time); 43 int text_input_type_time);
41 44
42 private: 45 private:
43 class DateTimeIPCSender; 46 class DateTimeIPCSender;
44 47
45 scoped_ptr<DateTimeIPCSender> communicator_; 48 scoped_ptr<DateTimeIPCSender> sender_;
46 base::android::ScopedJavaGlobalRef<jobject> j_date_time_chooser_; 49 base::android::ScopedJavaGlobalRef<jobject> j_date_time_chooser_;
47 50
48 DISALLOW_COPY_AND_ASSIGN(DateTimeChooserAndroid); 51 DISALLOW_COPY_AND_ASSIGN(DateTimeChooserAndroid);
49 }; 52 };
50 53
51 // Native JNI methods 54 // Native JNI methods
52 bool RegisterDateTimeChooserAndroid(JNIEnv* env); 55 bool RegisterDateTimeChooserAndroid(JNIEnv* env);
53 56
54 } // namespace content 57 } // namespace content
55 58
56 #endif // CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_ 59 #endif // CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/android/date_time_chooser_android.cc » ('j') | content/renderer/date_time_formatter.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698