Convert a RELEASE_ASSERT into an ASSERT

Source/core/paint/BlockPainter.cpp

Index: Source/core/paint/BlockPainter.cpp
diff --git a/Source/core/paint/BlockPainter.cpp b/Source/core/paint/BlockPainter.cpp
index 71faef3e1b742e970feb3d0272d0631882dcc58e..063137121ed707a7061a80678f5ff877bfa04c26 100644
--- a/Source/core/paint/BlockPainter.cpp
+++ b/Source/core/paint/BlockPainter.cpp
@@ -35,20 +35,20 @@ void BlockPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOff
     PaintPhase originalPhase = localPaintInfo.phase;
 
     // Check if we need to do anything at all.
-    // FIXME: Could eliminate the isDocumentElement() check if we fix background painting so that the LayoutView
-    // paints the root's background.
+    // TODO(schenney): Could eliminate the isDocumentElement() check if we fix background painting so
+    // that the LayoutView paints the root's background.

[trchen, 2015/07/13 20:23:18]

Yep now LayoutView paints root background.

+    // TODO(schenney): Test this code path, as breaking changes have failed to show up in testing.
+    // crbug.com/509737
     Node* blockNode = m_layoutBlock.node();
-    RELEASE_ASSERT(blockNode || m_layoutBlock.isAnonymous());
+    ASSERT(blockNode || m_layoutBlock.isAnonymous());
     if (blockNode) {
-        if (m_layoutBlock.isDocumentElement()) {
+        if (!m_layoutBlock.isDocumentElement()) {

[trchen, 2015/07/13 20:23:18]

It is probably okay to remove this check here. Does it break any tests if we
remove the check?

             LayoutRect overflowBox = overflowRectForPaintRejection();
             m_layoutBlock.flipForWritingMode(overflowBox);
             overflowBox.moveBy(adjustedPaintOffset);
             if (!overflowBox.intersects(LayoutRect(localPaintInfo.rect)))
                 return;
         }
-    } else {
-        RELEASE_ASSERT(!m_layoutBlock.isDocumentElement());
     }
 
     // There are some cases where not all clipped visual overflow is accounted for.