Convert a RELEASE_ASSERT into an ASSERT

Source/core/paint/BlockPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/BlockPainter.h"
 
 #include "core/editing/DragCaretController.h"
 #include "core/editing/FrameSelection.h"
 #include "core/frame/Settings.h"
@@ skipping 17 matching lines @@
 
 void BlockPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)
 {
     PaintInfo localPaintInfo(paintInfo);
 
     LayoutPoint adjustedPaintOffset = paintOffset + m_layoutBlock.location();
 
     PaintPhase originalPhase = localPaintInfo.phase;
 
     // Check if we need to do anything at all.
-    // FIXME: Could eliminate the isDocumentElement() check if we fix background painting so that the LayoutView
-    // paints the root's background.
+    // TODO(schenney): Could eliminate the isDocumentElement() check if we fix background painting so
+    // that the LayoutView paints the root's background.

[trchen, 2015/07/13 20:23:18]

Yep now LayoutView paints root background.

+    // TODO(schenney): Test this code path, as breaking changes have failed to show up in testing.
+    // crbug.com/509737
     Node* blockNode = m_layoutBlock.node();
-    RELEASE_ASSERT(blockNode || m_layoutBlock.isAnonymous());
+    ASSERT(blockNode || m_layoutBlock.isAnonymous());
     if (blockNode) {
-        if (m_layoutBlock.isDocumentElement()) {
+        if (!m_layoutBlock.isDocumentElement()) {

[trchen, 2015/07/13 20:23:18]

It is probably okay to remove this check here. Does it break any tests if we
remove the check?

             LayoutRect overflowBox = overflowRectForPaintRejection();
             m_layoutBlock.flipForWritingMode(overflowBox);
             overflowBox.moveBy(adjustedPaintOffset);
             if (!overflowBox.intersects(LayoutRect(localPaintInfo.rect)))
                 return;
         }
-    } else {
-        RELEASE_ASSERT(!m_layoutBlock.isDocumentElement());
     }
 
     // There are some cases where not all clipped visual overflow is accounted for.
     // FIXME: reduce the number of such cases.
     ContentsClipBehavior contentsClipBehavior = ForceContentsClip;
     if (m_layoutBlock.hasOverflowClip() && !m_layoutBlock.hasControlClip() && !(m_layoutBlock.shouldPaintSelectionGaps() && originalPhase == PaintPhaseForeground) && !hasCaret())
         contentsClipBehavior = SkipContentsClipIfPossible;
 
     if (localPaintInfo.phase == PaintPhaseOutline) {
         localPaintInfo.phase = PaintPhaseChildOutlines;
@@ skipping 285 matching lines @@
         LayoutBlock* block = flow->containingBlock();
         for ( ; block && block != &m_layoutBlock; block = block->containingBlock())
             accumulatedPaintOffset.moveBy(block->location());
         ASSERT(block);
         InlinePainter(*flow).paintOutline(info, accumulatedPaintOffset);
     }
 }
 
 
 } // namespace blink