Source/core/animation/ElementAnimations.cpp - Issue 1218943002: Compositor animations for Independent CSS Transform Properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ElementAnimations.cpp

Issue 1218943002: Compositor animations for Independent CSS Transform Properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Clean up Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/ElementAnimations.cpp

diff --git a/Source/core/animation/ElementAnimations.cpp b/Source/core/animation/ElementAnimations.cpp

index 86bee848ef2f11d7dbad838d16f62034caf42ed1..7bcfa569e8e80a3314792507526ee266c4a3008d 100644

--- a/Source/core/animation/ElementAnimations.cpp

+++ b/Source/core/animation/ElementAnimations.cpp

@@ -60,7 +60,10 @@ void ElementAnimations::updateAnimationFlags(ComputedStyle& style)

if (effect.isCurrent()) {

if (effect.affects(PropertyHandle(CSSPropertyOpacity)))

style.setHasCurrentOpacityAnimation(true);

- if (effect.affects(PropertyHandle(CSSPropertyTransform)))

+ if (effect.affects(PropertyHandle(CSSPropertyTransform))

Eric Willigers 2015/07/06 06:03:28 [Optional] Can we call isTransformRelatedEffect?

soonm 2015/07/06 23:36:50 Done - Yep that seems sound since the function onl

soonm 2015/07/06 23:36:50 Yep that seems sound since the function only deals

+ || effect.affects(PropertyHandle(CSSPropertyRotate))

+ || effect.affects(PropertyHandle(CSSPropertyScale))

+ || effect.affects(PropertyHandle(CSSPropertyTranslate)))

style.setHasCurrentTransformAnimation(true);

if (effect.affects(PropertyHandle(CSSPropertyWebkitFilter)))

style.setHasCurrentFilterAnimation(true);

« no previous file with comments | « Source/core/animation/DocumentAnimations.cpp ('k') | Source/core/animation/KeyframeEffect.h » ('j') | no next file with comments »