Compositor animations for Independent CSS Transform Properties

Source/core/animation/ElementAnimations.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 42 matching lines @@
 {
     for (const auto& entry : m_animations) {
         const Animation& animation = *entry.key;
         ASSERT(animation.source());
         // FIXME: Needs to consider AnimationGroup once added.
         ASSERT(animation.source()->isAnimation());
         const KeyframeEffect& effect = *toKeyframeEffect(animation.source());
         if (effect.isCurrent()) {
             if (effect.affects(PropertyHandle(CSSPropertyOpacity)))
                 style.setHasCurrentOpacityAnimation(true);
-            if (effect.affects(PropertyHandle(CSSPropertyTransform)))
+            if (effect.affects(PropertyHandle(CSSPropertyTransform))

[Eric Willigers, 2015/07/06 06:03:28]

[Optional] Can we call isTransformRelatedEffect?  The method could perhaps move
from CompositorAnimations.cpp to EffectModel.

[soonm, 2015/07/06 23:36:50]

Done - Yep that seems sound since the function only deals with the EffectModel

[soonm, 2015/07/06 23:36:50]

Yep that seems sound since the function only deals with the EffectModel

+                || effect.affects(PropertyHandle(CSSPropertyRotate))
+                || effect.affects(PropertyHandle(CSSPropertyScale))
+                || effect.affects(PropertyHandle(CSSPropertyTranslate)))
                 style.setHasCurrentTransformAnimation(true);
             if (effect.affects(PropertyHandle(CSSPropertyWebkitFilter)))
                 style.setHasCurrentFilterAnimation(true);
         }
     }
 
     if (style.hasCurrentOpacityAnimation())
         style.setIsRunningOpacityAnimationOnCompositor(m_defaultStack.hasActiveAnimationsOnCompositor(CSSPropertyOpacity));
     if (style.hasCurrentTransformAnimation())
         style.setIsRunningTransformAnimationOnCompositor(m_defaultStack.hasActiveAnimationsOnCompositor(CSSPropertyTransform));
@@ skipping 48 matching lines @@
     // TODO(rune@opera.com): The FontFaceCache version number may be increased without forcing
     // a style recalc (see crbug.com/471079). ComputedStyle objects created with different cache
     // versions will not be considered equal as Font::operator== will compare versions, hence
     // ComputedStyle::operator== will return false. We avoid using baseComputedStyle (the check for
     // isFallbackValid()) in that case to avoid triggering the ComputedStyle comparison ASSERT
     // in updateBaseComputedStyle.
     return m_animationStyleChange && (!m_baseComputedStyle || m_baseComputedStyle->font().isFallbackValid());
 }
 
 } // namespace blink