Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 1218943002: Compositor animations for Independent CSS Transform Properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add cancelling tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/KeyframeEffectModel.cpp ('k') | Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/css/CSSAnimatableValueFactory.cpp
diff --git a/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/Source/core/animation/css/CSSAnimatableValueFactory.cpp
index cd4539861b35d4a5924e6568175bf01d4f17a78f..5c98c826047b0030f4526ae1c3436cf61019fee0 100644
--- a/Source/core/animation/css/CSSAnimatableValueFactory.cpp
+++ b/Source/core/animation/css/CSSAnimatableValueFactory.cpp
@@ -59,6 +59,7 @@
#include "core/style/ComputedStyle.h"
#include "platform/Length.h"
#include "platform/LengthBox.h"
+#include "wtf/StdLibExtras.h"
namespace blink {
@@ -531,11 +532,14 @@ PassRefPtrWillBeRawPtr<AnimatableValue> CSSAnimatableValueFactory::create(CSSPro
case CSSPropertyTransform:
return AnimatableTransform::create(style.transform());
case CSSPropertyTranslate:
Eric Willigers 2015/07/05 23:03:29 CSSPropertyTranslate: { with closing brace before
soonm 2015/07/05 23:40:45 These changes should not have been in this patch.
- return createFromTransformProperties(style.translate(), style.initialTranslate());
+ DEFINE_STATIC_REF(TranslateTransformOperation, initialTranslate, TranslateTransformOperation::create(Length(0, Fixed), Length(0, Fixed), 0, TransformOperation::Translate3D));
+ return createFromTransformProperties(style.translate(), initialTranslate);
case CSSPropertyRotate:
- return createFromTransformProperties(style.rotate(), style.initialRotate());
+ DEFINE_STATIC_REF(RotateTransformOperation, initialRotate, RotateTransformOperation::create(0, 0, 1, 0, TransformOperation::Rotate3D));
+ return createFromTransformProperties(style.rotate(), initialRotate);
case CSSPropertyScale:
- return createFromTransformProperties(style.scale(), style.initialScale());
+ DEFINE_STATIC_REF(ScaleTransformOperation, initialScale, ScaleTransformOperation::create(1, 1, 1, TransformOperation::Scale3D));
+ return createFromTransformProperties(style.scale(), initialScale);
case CSSPropertyTransformOrigin:
return createFromTransformOrigin(style.transformOrigin(), style);
case CSSPropertyMotionOffset:
« no previous file with comments | « Source/core/animation/KeyframeEffectModel.cpp ('k') | Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698