Compositor animations for Independent CSS Transform Properties

Source/core/animation/css/CSSAnimatableValueFactory.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 41 matching lines @@
 #include "core/animation/animatable/AnimatableTransform.h"
 #include "core/animation/animatable/AnimatableUnknown.h"
 #include "core/animation/animatable/AnimatableVisibility.h"
 #include "core/css/CSSCalculationValue.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/CSSPrimitiveValueMappings.h"
 #include "core/css/CSSPropertyMetadata.h"
 #include "core/style/ComputedStyle.h"
 #include "platform/Length.h"
 #include "platform/LengthBox.h"
+#include "wtf/StdLibExtras.h"
 
 namespace blink {
 
 static PassRefPtrWillBeRawPtr<AnimatableValue> createFromLengthWithZoom(const Length& length, float zoom)
 {
     switch (length.type()) {
     case Fixed:
     case Percent:
     case Calculated:
         return AnimatableLength::create(length, zoom);
@@ skipping 451 matching lines @@
     case CSSPropertyShapeOutside:
         return createFromShapeValue(style.shapeOutside());
     case CSSPropertyShapeMargin:
         return createFromLength(style.shapeMargin(), style);
     case CSSPropertyShapeImageThreshold:
         return createFromDouble(style.shapeImageThreshold());
     case CSSPropertyWebkitTextStrokeColor:
         return createFromColor(property, style);
     case CSSPropertyTransform:
         return AnimatableTransform::create(style.transform());
     case CSSPropertyTranslate:

[Eric Willigers, 2015/07/05 23:03:29]

CSSPropertyTranslate: {
with closing brace before the next case.

Same for the next two cases.

[soonm, 2015/07/05 23:40:45]

These changes should not have been in this patch. 

It resolves a separate issue and submitted to another cl - Thanks for picking
this bug up :)

Going to be fixed with rebase master.

-        return createFromTransformProperties(style.translate(), style.initialTranslate());
+        DEFINE_STATIC_REF(TranslateTransformOperation, initialTranslate, TranslateTransformOperation::create(Length(0, Fixed), Length(0, Fixed), 0, TransformOperation::Translate3D));
+        return createFromTransformProperties(style.translate(), initialTranslate);
     case CSSPropertyRotate:
-        return createFromTransformProperties(style.rotate(), style.initialRotate());
+        DEFINE_STATIC_REF(RotateTransformOperation, initialRotate, RotateTransformOperation::create(0, 0, 1, 0, TransformOperation::Rotate3D));
+        return createFromTransformProperties(style.rotate(), initialRotate);
     case CSSPropertyScale:
-        return createFromTransformProperties(style.scale(), style.initialScale());
+        DEFINE_STATIC_REF(ScaleTransformOperation, initialScale, ScaleTransformOperation::create(1, 1, 1, TransformOperation::Scale3D));
+        return createFromTransformProperties(style.scale(), initialScale);
     case CSSPropertyTransformOrigin:
         return createFromTransformOrigin(style.transformOrigin(), style);
     case CSSPropertyMotionOffset:
         return createFromLength(style.motionOffset(), style);
     case CSSPropertyMotionRotation:
         return createFromDoubleAndBool(style.motionRotation(), style.motionRotationType() == MotionRotationAuto, style);
     case CSSPropertyWebkitPerspectiveOriginX:
         return createFromLength(style.perspectiveOriginX(), style);
     case CSSPropertyWebkitPerspectiveOriginY:
         return createFromLength(style.perspectiveOriginY(), style);
@@ skipping 33 matching lines @@
         if (style.hasAutoZIndex())
             return AnimatableUnknown::create(CSSValueAuto);
         return createFromDouble(style.zIndex());
     default:
         ASSERT_NOT_REACHED();
         return nullptr;
     }
 }
 
 } // namespace blink