win clang: don't disable -Wself-assign

third_party/lzma_sdk/7zAlloc.c

Index: third_party/lzma_sdk/7zAlloc.c
diff --git a/third_party/lzma_sdk/7zAlloc.c b/third_party/lzma_sdk/7zAlloc.c
index 964b28db38ec8f18ca7209e121258399a7ba56ed..d8cba7e5aec0646705019453c04e5a131eeff675 100644
--- a/third_party/lzma_sdk/7zAlloc.c
+++ b/third_party/lzma_sdk/7zAlloc.c
@@ -20,7 +20,6 @@ int g_allocCountTemp = 0;
 
 void *SzAlloc(void *p, size_t size)
 {
-  p = p;

[Nico, 2015/06/29 23:51:02]

I bet these are here to fix -Wunused-parameter warnings (which we don't enable).
If you want to upstream this, you probably want to remove p's name
(`SzAlloc(void*, size_t size)`) or change this line to `(void)p;`

[scottmg, 2015/06/30 00:32:55]

I don't think you can remove the argument names in C? (At least you can't in
VS).

Changed to disabling the warning locally rather than modifying the code as it
doesn't seem like a worthwhile enough change to bug upstream about.

   if (size == 0)
     return 0;
   #ifdef _SZ_ALLOC_DEBUG
@@ -32,7 +31,6 @@ void *SzAlloc(void *p, size_t size)
 
 void SzFree(void *p, void *address)
 {
-  p = p;
   #ifdef _SZ_ALLOC_DEBUG
   if (address != 0)
   {
@@ -45,7 +43,6 @@ void SzFree(void *p, void *address)
 
 void *SzAllocTemp(void *p, size_t size)
 {
-  p = p;
   if (size == 0)
     return 0;
   #ifdef _SZ_ALLOC_DEBUG
@@ -60,7 +57,6 @@ void *SzAllocTemp(void *p, size_t size)
 
 void SzFreeTemp(void *p, void *address)
 {
-  p = p;
   #ifdef _SZ_ALLOC_DEBUG
   if (address != 0)
   {