Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/libpng/libpng.gyp

Issue 1218903002: win clang: don't disable -Wself-assign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libpng/libpng.gyp
diff --git a/third_party/libpng/libpng.gyp b/third_party/libpng/libpng.gyp
index ac8fdb41c929c38ac8d85fbf2adf7efdc753ffd9..cb1bdecde50427a130fe53cafa13fcdf89ee9810 100644
--- a/third_party/libpng/libpng.gyp
+++ b/third_party/libpng/libpng.gyp
@@ -69,6 +69,15 @@
],
},
}],
+ ['OS=="win" and clang==1', {
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': [
+ '-Wno-self-assign', # http://crbug.com/505306.
Nico 2015/06/29 23:51:02 Likewise – add a 'variables': { 'clang_warn
scottmg 2015/06/30 00:32:55 Done.
+ ],
+ },
+ },
+ }],
['OS=="android"', {
'toolsets': ['target', 'host'],
'defines': [

Powered by Google App Engine
This is Rietveld 408576698