Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: third_party/libpng/BUILD.gn

Issue 1218903002: win clang: don't disable -Wself-assign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libpng/BUILD.gn
diff --git a/third_party/libpng/BUILD.gn b/third_party/libpng/BUILD.gn
index 787d4fa7d00ecb3b5e0dd237dd4cec24aa5d5a0e..f67a79f440562e29739e9b7f13a7a0ff0288835c 100644
--- a/third_party/libpng/BUILD.gn
+++ b/third_party/libpng/BUILD.gn
@@ -61,6 +61,10 @@ source_set("libpng_sources") {
public_deps = [
"//third_party/zlib",
]
+
+ if (is_win && is_clang) {
+ cflags = [ "-Wno-self-assign" ] # http://crbug.com/505306.
Nico 2015/06/29 23:51:02 Is the plan to fix these? If not and this is suppo
scottmg 2015/06/30 00:32:55 Done.
+ }
}
if (is_win) {

Powered by Google App Engine
This is Rietveld 408576698