Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: third_party/lzma_sdk/BUILD.gn

Issue 1218903002: win clang: don't disable -Wself-assign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix lzma_sdk and libpng for gn build Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libxml/src/xmlschemas.c ('k') | third_party/lzma_sdk/lzma_sdk.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/lzma_sdk/BUILD.gn
diff --git a/third_party/lzma_sdk/BUILD.gn b/third_party/lzma_sdk/BUILD.gn
index ac31fc1c2dc5e6cd4bf173987a6c60e25e70578c..2afe7b4f7e307c1c0d82c0591a748184a16f4f17 100644
--- a/third_party/lzma_sdk/BUILD.gn
+++ b/third_party/lzma_sdk/BUILD.gn
@@ -53,4 +53,14 @@ static_library("lzma_sdk") {
configs += [ "//build/config/compiler:no_chromium_code" ]
public_configs = [ ":lzma_sdk_config" ]
+
+ # Must be in a config because of how GN orders flags (otherwise -Wall will
+ # appear after this, and turn it back on).
+ config("clang_warnings") {
+ if (is_clang) {
+ # Upstream uses self-assignment to avoid warnings.
+ cflags = [ "-Wno-self-assign" ]
+ }
+ }
+ configs += [ ":clang_warnings" ]
}
« no previous file with comments | « third_party/libxml/src/xmlschemas.c ('k') | third_party/lzma_sdk/lzma_sdk.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698