third_party/libxml/src/xmlschemas.c - Issue 1218903002: win clang: don't disable -Wself-assign

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libxml/src/xmlschemas.c

Issue 1218903002: win clang: don't disable -Wself-assign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix lzma_sdk and libpng for gn build Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libxml/src/xmlschemas.c

diff --git a/third_party/libxml/src/xmlschemas.c b/third_party/libxml/src/xmlschemas.c

index 0657b66a1fde684e1ba69e308dc17372835f7417..971630e3787b9b53cba849296564470970e0c6e6 100644

--- a/third_party/libxml/src/xmlschemas.c

+++ b/third_party/libxml/src/xmlschemas.c

@@ -24201,9 +24201,7 @@ xmlSchemaValidateFacets(xmlSchemaAbstractCtxtPtr actxt,

* anySimpleType based types), then use the provided

* type.

- if (val == NULL)

- valType = valType;

- else

+ if (val != NULL)

valType = xmlSchemaGetValType(val);

ret = 0;

« no previous file with comments | « third_party/libxml/README.chromium ('k') | third_party/lzma_sdk/BUILD.gn » ('j') | no next file with comments »