Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 1218813005: Revert of Pretty print AlternativeService in test macros. (Closed)

Created:
5 years, 5 months ago by grt (UTC plus 2)
Modified:
5 years, 5 months ago
Reviewers:
Bence, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pretty print AlternativeService in test macros. (patchset #1 id:1 of https://codereview.chromium.org/1212813006/) Reason for revert: Introduced new static initializers: # http_server_properties.cc _GLOBAL__sub_I_http_server_properties.cc+0x10 # http_server_properties.cc std::ios_base::Init::Init()@plt # http_server_properties.cc __cxa_atexit@plt [registers a dtor to run at exit] Original issue's description: > Pretty print AlternativeService in test macros. > > Implement operator<<(std::ostream&, const AlternativeService&) so that when > EXPECT_EQ or ASSERT_EQ fails between two AlternativeService structs, the test > output contains protocol names and hostnames pretty printed, instead of a binary > blob including useless things like the memory address of where std::string > stores the hostname. > > Currently used in AlternateProtocolServerPropertiesTest.BrokenShadowsCanonical > only, but more tests involving EXPECT_EQ between AlternativeService structs are > coming. > > BUG=392575 > > Committed: https://crrev.com/a3542c2eb9d3760800d718c51eb9f573a42c6b42 > Cr-Commit-Position: refs/heads/master@{#336551} TBR=rch@chromium.org,bnc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=392575 Committed: https://crrev.com/518e46bc703661e7152312a9028c6a1ca13a3fa6 Cr-Commit-Position: refs/heads/master@{#336556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M net/http/http_server_properties.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/http/http_server_properties.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
Created Revert of Pretty print AlternativeService in test macros.
5 years, 5 months ago (2015-06-29 13:56:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218813005/1
5 years, 5 months ago (2015-06-29 13:56:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 13:57:04 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 13:58:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/518e46bc703661e7152312a9028c6a1ca13a3fa6
Cr-Commit-Position: refs/heads/master@{#336556}

Powered by Google App Engine
This is Rietveld 408576698