Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1218803005: Remove two useless attributes that snuck in while https://codereview.chromium.org/1221073004 was in… (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
stevenjb, benwells
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove two useless attributes that snuck in while https://codereview.chromium.org/1221073004 was in review. No intended behavior change. Should fix these errors on the clang/win bots: ../..\components/proxy_config/proxy_prefs.h(18,6) : error: 'dllexport' attribute only applies to variables, functions and classes [-Werror,-Wignored-attributes] enum PROXY_CONFIG_EXPORT ProxyMode { ^ ../..\components/proxy_config/proxy_config_export.h(12,40) : note: expanded from macro 'PROXY_CONFIG_EXPORT' ^ In file included from ../../components/proxy_config/proxy_prefs.cc:5: ../..\components/proxy_config/proxy_prefs.h(41,6) : error: 'dllexport' attribute only applies to variables, functions and classes [-Werror,-Wignored-attributes] enum PROXY_CONFIG_EXPORT ConfigState { ^ ../..\components/proxy_config/proxy_config_export.h(12,40) : note: expanded from macro 'PROXY_CONFIG_EXPORT' ^ BUG=504695 TBR=stevenjb,benwells Committed: https://chromium.googlesource.com/chromium/src/+/a6bb27acad7dde726d805d7ce880d85aed105869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/proxy_config/proxy_prefs.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Nico
5 years, 5 months ago (2015-07-06 20:39:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218803005/1
5 years, 5 months ago (2015-07-06 20:40:10 UTC) #4
Nico
5 years, 5 months ago (2015-07-06 21:00:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6bb27acad7dde726d805d7ce880d85aed105869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698