Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1218803002: Fix typo in big object fix for Windows. (Closed)

Created:
5 years, 5 months ago by Daniel Bratell
Modified:
5 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in big object fix for Windows. There is no such thing as VCCompilerTool so gyp did nothing but warn a thousand times. VCCLCompilerTool on the other hand will actually do something. BUG=500674 R=scottmg@chromium.org Committed: https://crrev.com/203d1bc92f3c8a33ea282d9512c6c8c5d8ca4cfa Cr-Commit-Position: refs/heads/master@{#336579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Daniel Bratell
5 years, 5 months ago (2015-06-29 10:24:35 UTC) #1
scottmg
On 2015/06/29 10:24:35, Daniel Bratell wrote: Oh, I'm an idiot! No wonder it didn't help! ...
5 years, 5 months ago (2015-06-29 15:17:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218803002/1
5 years, 5 months ago (2015-06-29 15:18:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 16:55:32 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/203d1bc92f3c8a33ea282d9512c6c8c5d8ca4cfa Cr-Commit-Position: refs/heads/master@{#336579}
5 years, 5 months ago (2015-06-29 16:56:26 UTC) #6
brucedawson
Hah - that's funny. That explains the 5,644 warnings when using the msvs-ninja generator: Warning: ...
5 years, 5 months ago (2015-06-29 17:23:07 UTC) #7
Daniel Bratell
5 years, 5 months ago (2015-06-29 20:12:37 UTC) #8
Message was sent while issue was closed.
On 2015/06/29 17:23:07, brucedawson wrote:
> Hah - that's funny. That explains the 5,644 warnings when using the msvs-ninja
> generator:
> 
>     Warning: unrecognized tool VCCompilerTool while converting to MSBuild.
> 
> This is the second recent instance of the msvs-ninja generator finding bugs
> (https://codereview.chromium.org/1208703002) that are not otherwise noticed.
> We'll have to keep that in mind.

It will also make running gyp_chromium from the prompt 10 seconds faster!
Because cmd.exe is crazy slow (trying to be compatible with MS-DOS speeds?) and
printing 5k warnings take a little while.

Powered by Google App Engine
This is Rietveld 408576698