Chromium Code Reviews

Issue 1208703002: Fix name of mojo test source file so it gets compiled. (Closed)

Created:
5 years, 6 months ago by brucedawson
Modified:
5 years, 6 months ago
Reviewers:
Ben Goodger (Google)
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix name of mojo test source file so it gets compiled. The .cc extension to js_to_cpp_tests.cc was omitted so the file has never been compiled and therefore the tests never run when using gyp files. The fix is to add the .cc. It is unfortunate that gyp silently ignores missing files. R=ben@chromium.org BUG=504157 Committed: https://crrev.com/590d6351fe0aa496622c7a8f9f4ada6851c5d892 Cr-Commit-Position: refs/heads/master@{#336028}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M third_party/mojo/mojo_edk_tests.gyp View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 6 (1 generated)
brucedawson
I get a few errors when I run mojo_js_integration_tests (on Windows) without this fix and ...
5 years, 6 months ago (2015-06-24 22:52:30 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 6 months ago (2015-06-24 23:06:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208703002/1
5 years, 6 months ago (2015-06-24 23:10:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 23:19:16 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 23:20:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/590d6351fe0aa496622c7a8f9f4ada6851c5d892
Cr-Commit-Position: refs/heads/master@{#336028}

Powered by Google App Engine