Issue 1218763002: Revert "Disable "Ok Google" hotwording in open source builds by default."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1218763002: Revert "Disable "Ok Google" hotwording in open source builds by default." (Closed)

Created:
5 years, 5 months ago by Matt Giuca

Modified:
5 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
https://chromium.googlesource.com/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Disable "Ok Google" hotwording in open source builds by default." This reverts commit 86fb78f02492b2990307ed427c09670f2fff0d3b. Commit broke the build due to merge failure. BUG=505351 TBR=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/12241d97a893992c4cf999ce85d82f71526d9800

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -44 lines)			Patch
M	build/common.gypi	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/BUILD.gn	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/search/hotword_service_unittest.cc	View	7 chunks	+14 lines, -32 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Matt Giuca

5 years, 5 months ago (2015-06-29 04:52:51 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
12241d97a893992c4cf999ce85d82f71526d9800 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages