Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 12186029: Merge 180012 (Closed)

Created:
7 years, 10 months ago by stevenjb
Modified:
7 years, 10 months ago
Reviewers:
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 180012 > Use ash NetworkIconAnimation in NetworkMenuIcon code > > This addresses two probles: > 1. Icon animations are not always in sync > 2. ash_system_tray_delegate uses 3 NetworkMenuIcon instances, which > can cause 3 * 60 = 180 animation updates per second. Limit this > by only sending a message when the index changes (5 times per > second). This isn't a perfect fix, but NetworkMenuIcon is being > deprecated soon... > > BUG=173156 > For ash.gyp: > TBR=sky@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/12094072 TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -127 lines) Patch
M ash/ash.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
MM ash/system/chromeos/network/network_icon.cc View 4 chunks +5 lines, -58 lines 0 comments Download
A + ash/system/chromeos/network/network_icon_animation.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/system/chromeos/network/network_icon_animation.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM ash/system/chromeos/network/network_icon_animation_observer.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon.h View 4 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon.cc View 15 chunks +59 lines, -58 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698