Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1218523003: Introduce layout test rendering a ligature composed of a space glyph (Closed)

Created:
5 years, 5 months ago by drott
Modified:
5 years, 5 months ago
Reviewers:
behdad_google, eae, kochi, behdad
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce layout test rendering a ligature composed of a space glyph Preparatory test to ensure that introducing word based caching in complex text does not break space ligatures and is disabled in this case. BUG=506517 R=eae,behdad Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
A LayoutTests/fast/text/space-ligature.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/space-ligature-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/third_party/AhemSpaceLigature/AhemSpaceLigature.woff View Binary file 0 comments Download
A LayoutTests/third_party/AhemSpaceLigature/LICENCE.txt View 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/third_party/AhemSpaceLigature/README View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
drott
PTAL
5 years, 5 months ago (2015-07-02 10:30:39 UTC) #1
behdad_google
lgtm
5 years, 5 months ago (2015-07-02 21:02:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218523003/1
5 years, 5 months ago (2015-07-03 13:52:41 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-03 13:52:43 UTC) #7
kochi
lgtm
5 years, 5 months ago (2015-07-06 07:33:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218523003/1
5 years, 5 months ago (2015-07-06 07:34:51 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 08:24:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198307

Powered by Google App Engine
This is Rietveld 408576698