Issue 12184004: Replace DialogFrameView with an enhanced BubbleFrameView.

Issue 12184004: Replace DialogFrameView with an enhanced BubbleFrameView. (Closed)

Created:
7 years, 10 months ago by msw

Modified:
7 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, alicet1, sadrul, msw+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace DialogFrameView with an enhanced BubbleFrameView. Add an *optional* title, (x) close button, and drag/resize to BubbleFrameView. (drag added via HTCAPTION, resize via DialogClientView's HTBOTTOMRIGHT) Use new DialogDelegate::CreateNewStyleFrameView(), remove DialogFrameView. TODO(followup): Use new title and close button in existing bubbles with similar. BUG=166075 TEST=No apparent difference for bubbles nor default dialogs; dialogs with --use-new-dialog-style can now resize from bottom-right. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180508

Patch Set 1 : Remove DialogFrameView, use enhanced BubbleFrameView. #

Patch Set 2 : Cleanup. #

Total comments: 2

Patch Set 3 : Address comment. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -218 lines)			Patch
M	ash/shell.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	ui/views/bubble/bubble_frame_view.h	View	1	4 chunks	+27 lines, -6 lines	0 comments	Download
M	ui/views/bubble/bubble_frame_view.cc	View	1	4 chunks	+76 lines, -3 lines	0 comments	Download
M	ui/views/views.gyp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/window/dialog_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/views/window/dialog_delegate.cc	View	1 2	2 chunks	+17 lines, -3 lines	0 comments	Download
D	ui/views/window/dialog_frame_view.h	View		1 chunk	+0 lines, -55 lines	0 comments	Download
D	ui/views/window/dialog_frame_view.cc	View		1 chunk	+0 lines, -142 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/12184004/diff/3003/ui/views/window/dialog_delegate.cc File ui/views/window/dialog_delegate.cc (right): https://codereview.chromium.org/12184004/diff/3003/ui/views/window/dialog_delegate.cc#newcode140 ui/views/window/dialog_delegate.cc:140: //static // static

7 years, 10 months ago (2013-02-04 18:25:35 UTC) #2

msw

Done; landing. https://codereview.chromium.org/12184004/diff/3003/ui/views/window/dialog_delegate.cc File ui/views/window/dialog_delegate.cc (right): https://codereview.chromium.org/12184004/diff/3003/ui/views/window/dialog_delegate.cc#newcode140 ui/views/window/dialog_delegate.cc:140: //static On 2013/02/04 18:25:35, sky wrote: > ...

7 years, 10 months ago (2013-02-04 18:44:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12184004/14001

7 years, 10 months ago (2013-02-04 18:46:12 UTC) #4

Message was sent while issue was closed.

Change committed as 180508

Expand Messages | Collapse Messages