Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: pkg/analysis_server/test/analysis/notification_navigation_test.dart

Issue 1218183007: Change navigation regions generation for constructors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_navigation.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/analysis/notification_navigation_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_navigation_test.dart b/pkg/analysis_server/test/analysis/notification_navigation_test.dart
index cc24ca3fdc48a29e89790c96755072b2ab1c165e..16d1bcd27c944aa4f78acc11240418169f1dfda4 100644
--- a/pkg/analysis_server/test/analysis/notification_navigation_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_navigation_test.dart
@@ -295,8 +295,14 @@ class B {
}
''');
return prepareNavigation().then((_) {
- assertHasRegionString('B.named');
- assertHasTarget('named();');
+ {
+ assertHasRegionString('B.named;', 'B'.length);
+ assertHasTarget('named();');
+ }
+ {
+ assertHasRegionString('named;', 'named'.length);
+ assertHasTarget('named();');
+ }
});
}
@@ -320,7 +326,7 @@ class C<T> {
assertHasTarget('A {');
}
{
- assertHasRegion('.named;', '.named'.length);
+ assertHasRegion('named;', 'named'.length);
assertHasTarget('named() {}');
}
});
@@ -445,7 +451,7 @@ main() {
}
''');
return prepareNavigation().then((_) {
- assertHasRegionString('new A');
+ assertHasRegionString('A()', 'A'.length);
assertHasTarget('A {');
});
}
@@ -460,7 +466,7 @@ main() {
''');
return prepareNavigation().then((_) {
{
- assertHasRegion('new B<A>', 'new B'.length);
+ assertHasRegion('B<A>', 'B'.length);
assertHasTarget('B<T> {');
}
{
@@ -480,8 +486,14 @@ main() {
}
''');
return prepareNavigation().then((_) {
- assertHasRegionString('new A.named');
- assertHasTarget('named() {}');
+ {
+ assertHasRegionString('A.named();', 'A'.length);
+ assertHasTarget('named() {}');
+ }
+ {
+ assertHasRegionString('named();', 'named'.length);
+ assertHasTarget('named() {}');
+ }
});
}
@@ -497,7 +509,7 @@ main() {
''');
return prepareNavigation().then((_) {
{
- assertHasRegionString('new B');
+ assertHasRegionString('B<A>', 'B'.length);
assertHasTarget('named() {}');
}
{
@@ -505,7 +517,7 @@ main() {
assertHasTarget('A {');
}
{
- assertHasRegion('.named();', '.named'.length);
+ assertHasRegion('named();', 'named'.length);
assertHasTarget('named() {}');
}
});
@@ -521,7 +533,7 @@ main() {
}
''');
return prepareNavigation().then((_) {
- assertHasRegionString('new A');
+ assertHasRegionString('A();', 'A'.length);
assertHasTarget('A() {}', 0);
});
}
@@ -538,7 +550,7 @@ main() {
''');
return prepareNavigation().then((_) {
{
- assertHasRegionString('new B');
+ assertHasRegionString('B<A>();', 'B'.length);
assertHasTarget('B() {}', 0);
}
{
« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_navigation.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698