Change navigation regions generation for constructors.

pkg/analysis_server/test/analysis/notification_navigation_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.analysis.notification.navigation;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol.dart';
@@ skipping 277 matching lines @@
   test_factoryRedirectingConstructor_named() {
     addTestFile('''
 class A {
   factory A() = B.named;
 }
 class B {
   B.named();
 }
 ''');
     return prepareNavigation().then((_) {
-      assertHasRegionString('B.named');
-      assertHasTarget('named();');
+      {
+        assertHasRegionString('B.named;', 'B'.length);
+        assertHasTarget('named();');
+      }
+      {
+        assertHasRegionString('named;', 'named'.length);
+        assertHasTarget('named();');
+      }
     });
   }
 
   test_factoryRedirectingConstructor_named_withTypeArgument() {
     addTestFile('''
 class A {}
 class B {
   factory B.named() = C<A>.named;
 }
 class C<T> {
   C.named() {}
 }
 ''');
     return prepareNavigation().then((_) {
       {
         assertHasRegion('C<A>');
         assertHasTarget('named() {}');
       }
       {
         assertHasRegion('A>.named');
         assertHasTarget('A {');
       }
       {
-        assertHasRegion('.named;', '.named'.length);
+        assertHasRegion('named;', 'named'.length);
         assertHasTarget('named() {}');
       }
     });
   }
 
   test_factoryRedirectingConstructor_unnamed() {
     addTestFile('''
 class A {
   factory A() = B;
 }
@@ skipping 104 matching lines @@
 
   test_instanceCreation_implicit() {
     addTestFile('''
 class A {
 }
 main() {
   new A();
 }
 ''');
     return prepareNavigation().then((_) {
-      assertHasRegionString('new A');
+      assertHasRegionString('A()', 'A'.length);
       assertHasTarget('A {');
     });
   }
 
   test_instanceCreation_implicit_withTypeArgument() {
     addTestFile('''
 class A {}
 class B<T> {}
 main() {
   new B<A>();
 }
 ''');
     return prepareNavigation().then((_) {
       {
-        assertHasRegion('new B<A>', 'new B'.length);
+        assertHasRegion('B<A>', 'B'.length);
         assertHasTarget('B<T> {');
       }
       {
         assertHasRegion('A>();', 'A'.length);
         assertHasTarget('A {');
       }
     });
   }
 
   test_instanceCreation_named() {
     addTestFile('''
 class A {
   A.named() {}
 }
 main() {
   new A.named();
 }
 ''');
     return prepareNavigation().then((_) {
-      assertHasRegionString('new A.named');
-      assertHasTarget('named() {}');
+      {
+        assertHasRegionString('A.named();', 'A'.length);
+        assertHasTarget('named() {}');
+      }
+      {
+        assertHasRegionString('named();', 'named'.length);
+        assertHasTarget('named() {}');
+      }
     });
   }
 
   test_instanceCreation_named_withTypeArgument() {
     addTestFile('''
 class A {}
 class B<T> {
   B.named() {}
 }
 main() {
   new B<A>.named();
 }
 ''');
     return prepareNavigation().then((_) {
       {
-        assertHasRegionString('new B');
+        assertHasRegionString('B<A>', 'B'.length);
         assertHasTarget('named() {}');
       }
       {
         assertHasRegion('A>.named');
         assertHasTarget('A {');
       }
       {
-        assertHasRegion('.named();', '.named'.length);
+        assertHasRegion('named();', 'named'.length);
         assertHasTarget('named() {}');
       }
     });
   }
 
   test_instanceCreation_unnamed() {
     addTestFile('''
 class A {
   A() {}
 }
 main() {
   new A();
 }
 ''');
     return prepareNavigation().then((_) {
-      assertHasRegionString('new A');
+      assertHasRegionString('A();', 'A'.length);
       assertHasTarget('A() {}', 0);
     });
   }
 
   test_instanceCreation_unnamed_withTypeArgument() {
     addTestFile('''
 class A {}
 class B<T> {
   B() {}
 }
 main() {
   new B<A>();
 }
 ''');
     return prepareNavigation().then((_) {
       {
-        assertHasRegionString('new B');
+        assertHasRegionString('B<A>();', 'B'.length);
         assertHasTarget('B() {}', 0);
       }
       {
         assertHasRegion('A>();');
         assertHasTarget('A {');
       }
     });
   }
 
   test_multiplyDefinedElement() {
@@ skipping 214 matching lines @@
   test_type_void() {
     addTestFile('''
 void main() {
 }
 ''');
     return prepareNavigation().then((_) {
       assertNoRegionAt('void');
     });
   }
 }