Issue 1218153006: Only define V8_USE_EXTERNAL_SNAPSHOT_DATA if we actually use a snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1218153006: Only define V8_USE_EXTERNAL_SNAPSHOT_DATA if we actually use a snapshot (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 5 months ago

Reviewers:
vogelheim

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Only define V8_USE_EXTERNAL_SNAPSHOT_DATA if we actually use a snapshot BUG=none R=vogelheim@chromium.org LOG=n Committed: https://crrev.com/55f27f77125f6af788b6d3d3a56ef9b2091c6559 Cr-Commit-Position: refs/heads/master@{#29445}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/features.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218153006/1

5 years, 5 months ago (2015-07-02 14:05:19 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-02 14:25:04 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/55f27f77125f6af788b6d3d3a56ef9b2091c6559
Cr-Commit-Position: refs/heads/master@{#29445}