build/features.gypi - Issue 1218153006: Only define V8_USE_EXTERNAL_SNAPSHOT_DATA if we actually use a snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/features.gypi

Issue 1218153006: Only define V8_USE_EXTERNAL_SNAPSHOT_DATA if we actually use a snapshot (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/features.gypi

diff --git a/build/features.gypi b/build/features.gypi

index cb69f880ef96cc7d7f7f94647764aa8ebfd21af9..76bfa22a77cb47f4c48606a91ffb5d8fd8dedf7e 100644

--- a/build/features.gypi

+++ b/build/features.gypi

@@ -97,7 +97,7 @@

['v8_enable_i18n_support==1', {

'defines': ['V8_I18N_SUPPORT',],

}],

- ['v8_use_external_startup_data==1', {

+ ['v8_use_snapshot=="true" and v8_use_external_startup_data==1', {

'defines': ['V8_USE_EXTERNAL_STARTUP_DATA',],

}],

['dcheck_always_on!=0', {

« no previous file with comments | « no previous file | no next file » | no next file with comments »